Build scaphandre without warp10 and containers features #211
Open
kraktus wants to merge 3 commits intohubblo-org:devfrom
Open
Build scaphandre without warp10 and containers features #211kraktus wants to merge 3 commits intohubblo-org:devfrom
warp10 and containers features #211kraktus wants to merge 3 commits intohubblo-org:devfrom
Conversation
refactor: use macro for exporters match from CLI
try to fix compilation
👇 Click on the image for a new way to code review
Legend |
kraktus
commented
Sep 3, 2022
| } | ||
|
|
||
| #[cfg(feature = "containers")] | ||
| struct ContainerData { |
Author
There was a problem hiding this comment.
There is probably a better name to be found
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While troubleshooting a build failure on ubuntu 22.04 due to conflicting openssl versions, I noticed that despite the dependencies being optional and put under a feature flag, scaphandre would not compile without them.
This PR aims to fix that. I tested it with and without features using the
stdoutexporter