8000 Lint fixes by gsnedders · Pull Request #222 · html5lib/html5lib-python · GitHub
[go: up one dir, main page]
Skip to content

Lint fixes #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Jan 12, 2016
Merged

Lint fixes #222

merged 16 commits into from
Jan 12, 2016

Conversation

gsnedders
Copy link
Member

This makes the lint filter actually ensure tree walker implementations follow their supposed API, runs all of the tree walker tests through the filter, and fixes a number of bugs it shows up.

@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/6056

Thi 10000 s is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@landscape-bot
Copy link

Code Health
Repository health decreased by 0.31% when pulling 74bedab on gsnedders:lint_fixes into 46dae3d on html5lib:master.

@gsnedders
Fix lint to expect text_type everywhere
40c3ba6
@gsnedders
Update lint filter for namespaced attributes
fbbea1f
@gsnedders
Drop the content model requirements from lint
8b4d7c4
@gsnedders
Don't let the lxml treewalker walk above the fragment root
270a2ca
@gsnedders
Teach lint & treewalkers that elements are only void in HTML ns
66ef026
@gsnedders
Use lint filter to ensure validity of treewalkers
5bd3413
@gsnedders
Remove runtime type checks from treewalkers._base
fb9e177
@gsnedders
Make sure we have the unicode from of text in lxml fragment root
2a5d7af
@gsnedders
Allow None as a doctype tagname in lint
9eff304
@gsnedders
Drop all the to_text magic in treewalkers._base
e0ea899
@gsnedders
Get rid of LintError and just use asserts
22c2b1a 
All of these properties should always hold per the API, so asserts
seem like a good match here.
@gsnedders
Lint that comments are text_type
5336ebe
@gsnedders
Don't allow ParseError/SerializerError tokens, whatever they are!
dc879ff
@gsnedde 8000 rs
Drop end tag tree walker's data (always empty now)
7f8bd13
@gsnedders
Drop tree walker doctype correct flag, whatever that once was!
c335295
@gsnedders
Make sure lint is testing everything treewalkers can do.
ca6591c
gsnedders added a commit that referenced this pull request Jan 12, 2016
@gsnedders
Merge pull request #222 from gsnedders/lint_fixes
73215c5 
Various fixes for the lint filter, and use it to validate treewalker sanity in tests.
@gsnedders gsnedders merged commit 73215c5 into html5lib:master Jan 12, 2016
@gsnedders gsnedders deleted the lint_fixes branch May 7, 2016 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gsnedders @hoppipolla-critic-bot @landscape-bot
0