8000 Move Dependency Into setup.py and Make Universal Wheel by dstufft · Pull Request #212 · html5lib/html5lib-python · GitHub
[go: up one dir, main page]
Skip to content

Move Dependency Into setup.py and Make Universal Wheel #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 13, 2015
Merged

Move Dependency Into setup.py and Make Universal Wheel #212

merged 4 commits into from
Nov 13, 2015

Conversation

dstufft
Copy link
Contributor
@dstufft dstufft commented Nov 12, 2015
  • Switches the setup.py to use setuptools.
  • Automatically installs ordereddict on Python < 2.7.
  • Adds extras which can be used to install optional dependencies like pip install html5lib[genshi,datrie]. The lxml extra is conditional on CPython.
  • Adds an all extra which will install all optional dependencies which correctly handles lxml on non CPython interpreters.
  • Marks wheels as universal.

Fixes #165
Fixes #179

@dstufft
Copy link
Contributor Author
dstufft commented Nov 12, 2015

Just an FYI:

  • This will work as expected on setuptools >= 0.7 but I think it sill silently fail to install orderedict on 2.6 and lxml when using the lxml or all extras on older setuptools.
  • This will work as expected on pip >= 6.0 but will silently fail to install ordereddict on 2.6 and lxml when using the lxml or all extras on older pip.

@gsnedders gsnedders merged commit dae03f6 into html5lib:master Nov 13, 2015
@gsnedders
Copy link
Member

Thanks!

@gsnedders
Copy link
Member

Bah, #179 still holds. The docs need to be updated to say we require ordereddict on 2.6 and require setuptools for install.

@dstufft dstufft deleted the setuptools-wheel branch November 13, 2015 12:59
@Ivoz
Copy link
Ivoz commented Nov 13, 2015

@gsnedders you can use this syntax in requirements files these days:

ordereddict; python_version < '2.7'

(also, since pip 6.0)

@gsnedders gsnedders mentioned this pull request Nov 23, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dstufft @gsnedders @Ivoz
0