Allow data URI schemes, with content type whitelist #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From https://en.wikipedia.org/wiki/Data_URI_scheme, allow the psuedo-protocol 'data'.
…tests to correctly check URIs
Conflicts: html5lib/sanitizer.py
|
Critic review: https://critic.hoppipolla.co.uk/r/1612 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
There are comments in the critic review, in case that wasn't obvious. |
added 4 commits
August 14, 2014 18:11
… to non-capturing subpatterns
|
Rebased into f644865. Thanks! Sorry for leaving the review for so long! |
|
No problem, glad to see it made it in! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, use proper URIs in the tests.
Note that the content type whitelist currently only contains 'image/png'; this can be filled out in a separate PR after a more complete discussion about allowable content types.