perf(entity.get): add attribute change tracking #15
Conversation
- improve re-render performance by ~2x on light pages - improve re-render performance by ~4x on heavy pages with ~10k components - only trigger re-renders on attributes that have changed - instrument `entity.get` to track used attributes and scope them to their respective hook - update the todo example to better leverage these new performance features - add performance section to readme
|
@rubinovitz when you get a chance to review this please also QA it locally. It touches a lot and I'd love another set of eyes on it. |
|
@smothers Sure thing!
…On Sat, Nov 14 2020 at 6:46 PM, Chris Smothers < ***@***.*** > wrote:
@rubinovitz ( https://github.com/rubinovitz ) when you get a chance to
review this please also QA it locally. It touches a lot and I'd love
another set of eyes on it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub (
#15 (comment)
) , or unsubscribe (
https://github.com/notifications/unsubscribe-auth/AANZMF6NUU4L2QOGS3XNCRTSP46GRANCNFSM4TV5IOJA
).
|
There was a problem hiding this comment.
@smothers I'm getting "Error: Invalid Hook" call when I try to render the Counter example now.
|
@smothers oh standby I think this is the problem I had last time I tried to test locally and it thinks there's two Reacts. 😬 I'll do the fix I did last time and test again in the morning. You don't need to do anything. |
|
@smothers I'm still getting the error after |
|
I'm getting the error if I use yarn, but npm lets me link to the local package |
|
🎉 This PR is included in version 0.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
entity.getto track used attributes and scope them to their respective hook