-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
Add config block to media selector #39696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It seems that this PR is targeted against an incorrect branch. Documentation updates which apply to our current stable release should target the |
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
00d72c9
to
41e7b81
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the blueprint selectors documentation to include examples and configuration details for the media selector.
- Added a new index entry for an example on merging with existing triggers.
- Provided usage examples for the media selector (with and without an
accept
filter). - Introduced a configuration block for the
accept
option.
Comments suppressed due to low confidence (2)
source/_docs/blueprint/selectors.markdown:1043
- The code snippet includes a stray hyphen before the comment. Change
-#
to#
so that the YAML example is valid.
```yaml
source/_docs/blueprint/selectors.markdown:1049
- The configuration block appears incomplete and uses
configuration area
. It should follow the established pattern by wrapping the fullmedia
selector configuration under{% configuration %}
and including the parent key (for example,media:
then nestedselector
details).
{% configuration area %}
📝 WalkthroughWalkthroughThe documentation for the media selector was updated to include two new usage examples and a configuration block describing the optional Changes
Sequence Diagram(s)No sequence diagram generated as the changes are limited to documentation updates. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
source/_docs/blueprint/selectors.markdown (1)
1056-1056
: Tiny grammar nit – “a mapping”, not “an mapping”-The output of the media selector, is an mapping with information about +The output of the media selector is a mapping with information about
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
source/_docs/blueprint/selectors.markdown
(2 hunks)
🔇 Additional comments (2)
source/_docs/blueprint/selectors.markdown (2)
1032-1041
: Clarity additions look goodNice addition of concrete usage examples for both the default and
accept
-filtered variants; phrasing is clear and matches actual behaviour in the UI.
1197-1197
: Indentation fix restores YAML correctnessThe extra two-space indent for
selector:
aligns the sample with previous code blocks and prevents copy-paste errors.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @balloob 👍
../Frenck
Proposed change
Add missing config block for media selector.
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit