-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
Add Google Weather docs #39589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Add Google Weather docs #39589
Conversation
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
📝 WalkthroughWalkthroughA new documentation file for the "Google Weather" integration has been added. It details setup instructions, usage, API key requirements, polling intervals, request estimates, known limitations, and troubleshooting for integrating Google Weather as a weather data source in Home Assistant. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant HomeAssistant
participant GoogleWeatherAPI
User->>HomeAssistant: Add Google Weather integration
HomeAssistant->>User: Prompt for API key
User->>HomeAssistant: Provide API key
HomeAssistant->>GoogleWeatherAPI: Authenticate and request weather data (every 15 min / hourly forecasts)
GoogleWeatherAPI-->>HomeAssistant: Return current and forecast weather data
HomeAssistant-->>User: Display weather information
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
source/_integrations/google_weather.markdown (2)
32-36
: Surround lists with blank lines (MD032)
The list under “Data updates” must be preceded and followed by a blank line to satisfy lint rules.
Apply this diff:@@ -32,4 +32,6 The integration fetches: + - current weather conditions every 15 minutes - daily weather forecast every 2 hours - hourly weather forecast every 2 hours +
45-45
: Correct capitalization of "Google Weather"
Ensure consistent branding by capitalizing “Weather” in the Known limitations section.
Apply this diff:- - Google weather forecast information isn't currently available in South Korea and Japan. See [here](https://support.google.com/websearch/answer/13687874). + - Google Weather forecast information isn't currently available in South Korea and Japan. See [here](https://support.google.com/websearch/answer/13687874).
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
source/_integrations/google_weather.markdown
(1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
source/_integrations/google_weather.markdown
33-33: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (3)
source/_integrations/google_weather.markdown (3)
32-35
: List Formatting: Surround list with blank lines
Insert a blank line between the “The integration fetches:” paragraph and the bullet list to satisfy markdown list spacing guidelines.
37-37
: Clarify request estimate calculation
Consider specifying that the 4,464-requests/month figure is based on a 31-day month so users understand the basis of the estimate.
45-46
: Capitalization: Consistent integration name
Change “Google weather forecast” to “Google Weather forecast” to match the integration’s name.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
source/_integrations/google_weather.markdown
(1 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/google_weather.markdown
[grammar] ~34-~34: When ‘1-hour’ is used as a modifier, it is usually spelled with a hyphen.
Context: ...minutes
- daily weather forecast every 1 hour
- hourly weather forecast every 1 hour...
(HOUR_HYPHEN)
[uncategorized] ~35-~35: A period might be missing here.
Context: ...hour
- hourly weather forecast every 1 hour
This results in 4,464 requests per m...
(AI_EN_LECTOR_MISSING_PUNCTUATION_PERIOD)
🪛 markdownlint-cli2 (0.17.2)
source/_integrations/google_weather.markdown
33-33: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
🔇 Additional comments (5)
source/_integrations/google_weather.markdown (5)
1-16
: Front Matter: Fields look correct
The YAML metadata includes all required keys (title
,description
,ha_category
,ha_release
, etc.) and follows Home Assistant documentation conventions.
18-19
: Description: Integration macro and link are accurate
The{% term integration %}
macro is used correctly, and the link to Google’s Weather API documentation is valid.
20-28
: Prerequisites section is clear
API key requirement and links for obtaining keys and pricing are well explained.
39-42
: Removal instructions include is correct
Theintegrations/remove_device_service.md
include provides the standard removal workflow.
47-50
: Troubleshooting instructions are clear
Debug logging guidance is appropriate and follows Home Assistant norms.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (4)
source/_integrations/google_weather.markdown (4)
22-22
: Use descriptive link text instead of “here”.Avoid generic “here” links for accessibility and clarity. For example:
-You need an API key. Follow instructions [here](https://developers.google.com/maps/documentation/weather/get-api-key) for creating an API key. +You need a Google Maps API key. Follow the [Get an API key guide](https://developers.google.com/maps/documentation/weather/get-api-key) to create one.
35-36
: Clean up interval wording and hyphenation.Instead of “every 1 hour,” use “every hour” or simply “hourly” for clarity and consistency. For example:
-- daily weather forecast for the next 10 days every 1 hour -- hourly weather forecast for the next 24 hours every 1 hour +- daily weather forecast for the next 10 days (hourly) +- hourly weather forecast for the next 24 hours (hourly)
38-38
: Clarify monthly request calculation.The doc states 4,464 requests per month, which assumes a 31-day month. Consider noting the assumption or using a 30-day baseline to avoid confusion:
-This results in 4,464 requests per month, meaning you could have up to 2 locations and still stay under the 10,000 free usage cap. +Assuming a 31-day month, this results in 4,464 requests per month. Even on a 30-day month (≈4,320 requests), you can monitor up to two locations and remain under the 10,000 free-tier cap.
50-51
: Enhance troubleshooting with a debug config sample.It’s helpful to show users how to enable debug logging for this integration. For example:
```yaml # configuration.yaml logger: default: warning logs: homeassistant.components.google_weather: debug</blockquote></details> </blockquote></details> <details> <summary>📜 Review details</summary> **Configuration used: CodeRabbit UI** **Review profile: CHILL** **Plan: Pro** **Cache: Disabled due to data retention organization setting** **Knowledge Base: Disabled due to data retention organization setting** <details> <summary>📥 Commits</summary> Reviewing files that changed from the base of the PR and between f0093a863a7fa1fa9a7a8668755096d72a069736 and 5415a44f16b755d63d896c0460b6d0666f0cf05e. </details> <details> <summary>📒 Files selected for processing (1)</summary> * `source/_integrations/google_weather.markdown` (1 hunks) </details> <details> <summary>🧰 Additional context used</summary> <details> <summary>🪛 LanguageTool</summary> <details> <summary>source/_integrations/google_weather.markdown</summary> [grammar] ~35-~35: When ‘1-hour’ is used as a modifier, it is usually spelled with a hyphen. Context: ...her forecast for the next 10 days every 1 hour - hourly weather forecast for the next... (HOUR_HYPHEN) </details> </details> </details> </details> <!-- This is an auto-generated comment by CodeRabbit for review status -->
Co-authored-by: Simon Lamon <32477463+silamon@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (3)
source/_integrations/google_weather.markdown (3)
36-38
: Simplify frequency phrasing for consistencyRecommend replacing “every 1 hour” with “every hour” and removing redundant terms (e.g., “hourly weather forecast” already implies hourly frequency). This improves readability and parallelism in the bullet list.
48-48
: Use descriptive link text instead of “here”Avoid generic link labels; replace “[here]” with a descriptive label such as “[Google support page for region availability]” to improve accessibility and clarity.
52-52
: Wrap troubleshooting advice in an admonitionConsider using a note admonition instead of a bullet for the troubleshooting step to increase visibility (e.g.,
{% note %}Enable debug logging and attach logs before opening an issue.{% endnote %}
).
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
source/_integrations/google_weather.markdown
(1 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/google_weather.markdown
[grammar] ~37-~37: When ‘1-hour’ is used as a modifier, it is usually spelled with a hyphen.
Context: ...her forecast for the next 10 days every 1 hour
- hourly weather forecast for the next...
(HOUR_HYPHEN)
⏰ Context from c 8000 hecks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
🔇 Additional comments (3)
source/_integrations/google_weather.markdown (3)
1-16
: Frontmatter validated and conforms to standardsAll required frontmatter fields (title, description, category, release version, IoT class, config flow, domain, code owners, integration type, quality scale, and platforms) are correctly specified and formatted.
18-23
: Prerequisites section is clear and completeThe instructions for obtaining an API key are concise, and the link to Google’s documentation is correct.
24-28
: Note block properly highlights GA preview statusThe implementation of the note admonition is correct and follows documentation conventions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
source/_integrations/google_weather.markdown (2)
24-29
: Add the missing comma in the billing sentenceMinor punctuation issue flagged by LanguageTool—add a comma after “GA”.
-For pricing once it's in GA refer to the [billing section in the Google developer documentation](https://developers.google.com/maps/documentation/weather/usage-and-billing). +For pricing once it's in GA, refer to the [billing section in the Google developer documentation](https://developers.google.com/maps/documentation/weather/usage-and-billing).
37-40
: Tighten phrasing of update cadence (hyphen/wording)“Every 1 hour” reads awkwardly and triggers the
HOUR_HYPHEN
lint warning. Simplify to “every hour”.- - daily weather forecast for the next 10 days every 1 hour - - hourly weather forecast for the next 24 hours every 1 hour + - daily weather forecast for the next 10 days every hour + - hourly weather forecast for the next 24 hours every hour
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
source/_integrations/google_weather.markdown
(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`source/_integrations/*`: Integration documentation must use the provided template structure and section order.
source/_integrations/*
: Integration documentation must use the provided template structure and section order.
📄 Source: CodeRabbit Inference Engine (.github/copilot-instructions.md)
List of files the instruction was applied to:
source/_integrations/google_weather.markdown
🪛 LanguageTool
source/_integrations/google_weather.markdown
[uncategorized] ~26-~26: A comma might be missing here.
Context: ...ring Preview.
For pricing once it's in GA refer to the [billing section in the Go...
(AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)
[grammar] ~38-~38: When ‘1-hour’ is used as a modifier, it is usually spelled with a hyphen.
Context: ...her forecast for the next 10 days every 1 hour
- hourly weather forecast for the next...
(HOUR_HYPHEN)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
🔇 Additional comments (1)
source/_integrations/google_weather.markdown (1)
6-6
: Double-check theha_release
placeholder before merge
ha_release: '2025.7'
is forward-looking. Make sure the value matches the actual Home Assistant version in which the integration will ship; otherwise the docs site will surface the page under the wrong release tag.
Proposed change
Add Google Weather docs
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit