-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
Update airthings.markdown to reflect the latency in adding the radon … #39552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: current
Are you sure you want to change the base?
Conversation
…sensor. I noticed that the radon sensor entity was not created when the device was newly added - the Airthings API itself won't return a value until the sensor actually has a known value. Since this could be confusing, I added a tip to the documention to try and help folks understand it. This would only happen if you added a new device to Airthings and immediately added it to Home Assistant.
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
📝 WalkthroughWalkthroughA new informational tip was added to the Airthings integration documentation, clarifying that radon sensor data is initially not published by the Airthings API and may be considered "unknown" at device startup. Users may need to wait for the radon sensor to appear for new devices. No functional or code changes were made. Changes
Sequence Diagram(s)No sequence diagram generated as the change is limited to documentation. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
source/_integrations/airthings.markdown (1)
30-32
: Condense multiple blank linesThere are three consecutive blank lines after the tip; markdownlint (MD012) expects only one. Please collapse them to a single blank line before the “## Prerequisites” heading.
@@ -{% tip %} ... {% endtip %} - - - +{% tip %} ... {% endtip %} ## Prerequisites🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
31-31: Multiple consecutive blank lines
Expected: 1; Actual: 2(MD012, no-multiple-blanks)
32-32: Multiple consecutive blank lines
Expected: 1; Actual: 3(MD012, no-multiple-blanks)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
source/_integrations/airthings.markdown
(1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
source/_integrations/airthings.markdown
31-31: Multiple consecutive blank lines
Expected: 1; Actual: 2
(MD012, no-multiple-blanks)
32-32: Multiple consecutive blank lines
Expected: 1; Actual: 3
(MD012, no-multiple-blanks)
🪛 GitHub Actions: home-assistant.io Test
source/_integrati 8000 ons/airthings.markdown
[error] 29-29: Textlint: This is a commonly misspelled word. Correct it to 'initially' (rule: common-misspellings)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
@@ -26,6 +26,10 @@ While this integration works without an Airthings SmartLink hub, using one will | |||
|
|||
Requires Airthings hardware and a valid Airthings Dashboard login. | |||
|
|||
{% tip %} Initally, the radon sensor not published from the Airthings API (it is considered "unknown"), and so you may have to wait 24 hours to see the radon sensor appear for a new device.{% endtip %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix spelling and improve grammar in informational tip
The pipeline is flagging a misspelling (“Initally”) and the phrasing is awkward. Update to:
-{% tip %} Initally, the radon sensor not published from the Airthings API (it is considered "unknown"), and so you may have to wait 24 hours to see the radon sensor appear for a new device.{% endtip %}
+{% tip %} Initially, the radon sensor is not published by the Airthings API (it is considered “unknown”), so you may have to wait up to 24 hours to see the radon sensor appear for a new device.{% endtip %}
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
{% tip %} Initally, the radon sensor not published from the Airthings API (it is considered "unknown"), and so you may have to wait 24 hours to see the radon sensor appear for a new device.{% endtip %} | |
{% tip %} Initially, the radon sensor is not published by the Airthings API (it is considered “unknown”), so you may have to wait up to 24 hours to see the radon sensor appear for a new device.{% endtip %} |
🧰 Tools
🪛 GitHub Actions: home-assistant.io Test
[error] 29-29: Textlint: This is a commonly misspelled word. Correct it to 'initially' (rule: common-misspellings)
🤖 Prompt for AI Agents
In source/_integrations/airthings.markdown at line 29, correct the spelling of
"Initally" to "Initially" and improve the grammar of the tip by rephrasing it
for clarity and smoothness. Ensure the sentence clearly states that the radon
sensor is initially not published by the Airthings API and may take up to 24
hours to appear for a new device.
Fixed to handle automated comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
♻️ Duplicate comments (1)
source/_integrations/airthings.markdown (1)
29-29
: 🛠️ Refactor suggestionFix grammar in the informational tip.
The sentence is missing the verb “is” and can be streamlined for clarity. Suggest updating to:
-{% tip %} Initially, the radon sensor not published by the Airthings API (it is considered "unknown"), and so you may have to wait 24 hours to see the radon sensor appear for a new device.{% endtip %} +{% tip %} Initially, the radon sensor is not published by the Airthings API (it is considered "unknown"), so you may have to wait up to 24 hours for it to appear on a new device.{% endtip %}
🧹 Nitpick comments (1)
source/_integrations/airthings.markdown (1)
30-32
: Remove extra blank lines.Markdownlint flags multiple consecutive blank lines. Collapse these to a single blank line between the tip and the next section to satisfy MD012.
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
31-31: Multiple consecutive blank lines
Expected: 1; Actual: 2(MD012, no-multiple-blanks)
32-32: Multiple consecutive blank lines
Expected: 1; Actual: 3(MD012, no-multiple-blanks)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
source/_integrations/airthings.markdown
(1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
source/_integrations/airthings.markdown
31-31: Multiple consecutive blank lines
Expected: 1; Actual: 2
(MD012, no-multiple-blanks)
32-32: Multiple consecutive blank lines
Expected: 1; Actual: 3
(MD012, no-multiple-blanks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
source/_integrations/airthings.markdown (2)
29-29
: Fix grammar and improve clarity in the informational tip.The phrase "wait for the radon sensor appear" is missing "to" and could be clearer. Consider the following revision:
-{% tip %} Initially, the radon sensor may not be published by the Airthings API (at device startup the value is considered "unknown"), and so you may have to wait for the radon sensor appear for a new device.{% endtip %} +{% tip %} Initially, the radon sensor data is not published by the Airthings API (the value is considered “unknown” at device startup), so you may have to wait up to 24 hours for the radon sensor to appear for a new device.{% endtip %}🧰 Tools
🪛 LanguageTool
[uncategorized] ~29-~29: Possible missing preposition found.
Context: ...u may have to wait for the radon sensor appear for a new device.{% endtip %} ## Pre...(AI_HYDRA_LEO_MISSING_TO)
30-32
: Remove extra blank lines.Markdownlint flags multiple consecutive blank lines here. Reduce to a single blank line after the tip:
@@ lines 30-32 - - +🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
31-31: Multiple consecutive blank lines
Expected: 1; Actual: 2(MD012, no-multiple-blanks)
32-32: Multiple consecutive blank lines
Expected: 1; Actual: 3(MD012, no-multiple-blanks)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
source/_integrations/airthings.markdown
(1 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/airthings.markdown
[uncategorized] ~29-~29: Possible missing preposition found.
Context: ...u may have to wait for the radon sensor appear for a new device.{% endtip %} ## Pre...
(AI_HYDRA_LEO_MISSING_TO)
🪛 markdownlint-cli2 (0.17.2)
source/_integrations/airthings.markdown
31-31: Multiple consecutive blank lines
Expected: 1; Actual: 2
(MD012, no-multiple-blanks)
32-32: Multiple consecutive blank lines
Expected: 1; Actual: 3
(MD012, no-multiple-blanks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
@@ -26,6 +26,10 @@ While this integration works without an Airthings SmartLink hub, using one will | |||
|
|||
Requires Airthings hardware and a valid Airthings Dashboard login. | |||
|
|||
{% tip %} Initially, the radon sensor may not be published by the Airthings API (at device startup the value is considered "unknown"), and so you may have to wait for the radon sensor appear for a new device.{% endtip %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe this could be moved to a troubleshooting section at the end of this page?
I'm drafting this PR, as changes are needed. Please undraft it, once the changes have been implemented and the PR is ready for review again. |
…sensor.
I noticed that the radon sensor entity was not created when the device was newly added - the Airthings API itself won't return a value until the sensor actually has a known value. Since this could be confusing, I added a tip to the documention to try and help folks understand it. This would only happen if you added a new device to Airthings and immediately added it to Home Assistant.
Proposed change
I noticed that the radon sensor entity was not created when the device was newly added - the Airthings API itself won't return a value until the sensor actually has a known value. Since this could be confusing, I added a tip to the documention to try and help folks understand it. This would only happen if you added a new device to Airthings and immediately added it to Home Assistant.
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit