8000 Update pricing for VPE by mrdarrengriffin · Pull Request #39313 · home-assistant/home-assistant.io · GitHub
[go: up one dir, main page]
Skip to content
10000

Update pricing for VPE #39313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 31, 2025
Merged

Update pricing for VPE #39313

merged 1 commit into from
May 31, 2025

Conversation

mrdarrengriffin
Copy link
Contributor
@mrdarrengriffin mrdarrengriffin commented May 29, 2025 •
edited by coderabbitai bot
Loading

Proposed change

Updating pricing and terms for the Voice Preview Edition

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue: fixes #

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Summary by CodeRabbit

  • New Features

    • Updated pricing display to show both US dollar and Euro amounts.
    • Expanded pricing disclaimer to clarify regional price differences.

  • Style

    • Improved mobile and desktop font sizing for the price display.
    • Adjusted spacing around the pricing section for better visual consistency across devices.

@home-assistant home-assistant bot added the current This PR goes into the current branch label May 29, 2025
@netlify Netlify
Copy link
netlify bot commented May 29, 2025 •
edited
Loading

✅ Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit 71011bb
🔍 Latest deploy log https://app.netlify.com/projects/home-assistant-docs/deploys/683854d74e48680008901a3e
😎 Deploy Preview https://deploy-preview-39313--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@mrdarrengriffin mrdarrengriffin marked this pull request as ready for review May 29, 2025 12:37
@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented May 29, 2025
📝 Walkthrough

Walkthrough

The changes update the pricing section in the HTML to display both USD and Euro prices and clarify the pricing disclaimer. CSS modifications adjust the font size and margin of the price display for different screen widths, improving responsiveness and spacing across devices.

Changes

File(s) Change Summary
source/voice-pe/index.html Updated displayed price from "$59" to "$69 / €59" and expanded the pricing disclaimer for regional clarity.
source/voice-pe/styles.css Adjusted price font size and margin for mobile and desktop breakpoints to improve responsive layout.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Browser
    participant HTML
    participant CSS

    User->>Browser: Loads pricing page
    Browser->>HTML: Renders price as "$69 / €59"
    Browser->>CSS: Applies font size and margin based on screen width
    HTML->>User: Displays updated price and disclaimer
Loading

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed May 29, 2025
View reviewed changes
Copy link
Contributor
@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🧹 Nitpick comments (3)
source/voice-pe/styles.css (1)

2889-2892: Consolidate and test pricing margin adjustments
The default margin-bottom for #pricing .fs-price was reduced from -20px to -10px. Verify that this new spacing works well with the expanded dual-currency text and related elements. Also, note there are subsequent overrides targeting the same selector—consider consolidating these rules to prevent conflicts.

source/voice-pe/index.html (2)

211-211: Dual currency pricing correctly displayed
The updated markup now shows both USD and EUR amounts. Using the numeric entity &#8364; works, but for readability and consistency you may consider the named entity &euro;. Also, wrapping each currency value in its own <span> (e.g. <span class="price-usd">$69</span><span class="separator">/</span><span class="price-eur">&euro;59</span>) would make styling and future localization much easier.

220-220: Link pricing disclaimer for improved accessibility
Great clarification of the disclaimer text. To ensure screen readers associate the asterisk with its explanation, connect them via aria-describedby. For example, give the <small> an id="price-disclaimer" and add aria-describedby="price-disclaimer" on the asterisk span.

Example diff:

- <div class="fs-price">&#x24;69 / &#8364;59 <span>*</span></div>
+ <div class="fs-price" aria-describedby="price-disclaimer">
+   <span class="price-usd">$69</span> <span class="separator">/</span> <span class="price-eur">&euro;59</span>
+   <span id="price-disclaimer-ref" aria-hidden="true">*</span>
+ </div>
...
- <small>* Recommended MSRP. Prices differ between regions due to varying local market costs and conditions, and subject to individual retailers.</small>
+ <small id="price-disclaimer">* Recommended MSRP. Prices differ between regions due to varying local market costs and conditions, and subject to individual retailers.</small>
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 3d4fd0d and 71011bb.

📒 Files selected for processing (2)
  • source/voice-pe/index.html (2 hunks)
  • source/voice-pe/styles.css (4 hunks)
🔇 Additional comments (3)
source/voice-pe/styles.css (3)

177-177: Verify mobile --price-mobile adjustment works across breakpoints
The default --price-mobile was reduced from 120px to 60px for smaller viewports (<875px). Please validate this new size on real devices or emulators to ensure legibility with the dual-currency display.

178-178: This blank line change is purely cosmetic and doesn’t affect rendering.

180-180: This blank line change is also cosmetic.

@silamon silamon merged commit cb6c87d into current May 31, 2025
9 checks passed
@silamon silamon deleted the vpe-pricing-update branch May 31, 2025 01:02
@github-actions github-actions bot locked and limited conversation to collaborators Jun 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@silamon silamon silamon approved these changes

Assignees
No one assigned
Labels
current This PR goes into the current branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrdarrengriffin @silamon
0