-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
Storing emergency kit: clarify steps #37326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Warning Rate limit exceeded@c0ffeeca7 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 4 minutes and 13 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe update refines the documentation on encryption key management for backups. It clarifies that Home Assistant tracks the current encryption key and can decrypt backups when they are downloaded directly, while specifying that the old key is required if the encryption key has been changed since the backup was created. Additionally, the section on retrieving a lost encryption key and the instructions for generating a new one have been expanded and updated for clearer guidance. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
source/more-info/backup-emergency-kit.markdown (2)
26-27
: Improve Wording for ClarityThe new bullet points clarify that Home Assistant tracks the current encryption key and that an old key is needed if it’s been changed. Consider removing the phrase “in the meantime” to streamline the sentence. For example:
- - But if you have changed the encryption key in the meantime, you still need the old key that matches old backups. + - But if you have changed the encryption key, you still need the old key that matches backups created before the change.🧰 Tools
🪛 LanguageTool
[style] ~27-~27: ‘in the meantime’ might be wordy. Consider a shorter alternative.
Context: ... if you have changed the encryption key in the meantime, you still need the old key that matche...(EN_WORDINESS_PREMIUM_IN_THE_MEANTIME)
43-46
: Refine Language for ConsistencyIn the section about retrieving a lost encryption key, consider these adjustments:
- On line 46, replace “can not” with “cannot” for conventional usage.
- Similarly, remove “in the meantime” for a more concise expression.
A suggested diff for line 46:
- - **If you have changed the encryption key in the meantime**: Home Assistant can not decrypt it on the fly. You need the encryption key that is related to that backup. If you have lost the encryption key, and have no access to your Home Assistant instance, there is no way to restore the backup. + - **If you have changed the encryption key**: Home Assistant cannot decrypt the backup on the fly. You need the previous encryption key for backups created before the change. If you have lost that key and no longer have access to your Home Assistant instance, the backup cannot be restored.🧰 Tools
🪛 LanguageTool
[style] ~46-~46: ‘in the meantime’ might be wordy. Consider a shorter alternative.
Context: ...If you have changed the encryption key in the meantime*: Home Assistant can not decrypt it on...(EN_WORDINESS_PREMIUM_IN_THE_MEANTIME)
[style] ~46-~46: Unless you want to emphasize “not”, use “cannot” which is more common.
Context: ...n key in the meantime**: Home Assistant can not decrypt it on the fly. You need the enc...(CAN_NOT_PREMIUM)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/more-info/backup-emergency-kit.markdown
(2 hunks)
🧰 Additional context used
🪛 LanguageTool
source/more-info/backup-emergency-kit.markdown
[style] ~27-~27: ‘in the meantime’ might be wordy. Consider a shorter alternative.
Context: ... if you have changed the encryption key in the meantime, you still need the old key that matche...
(EN_WORDINESS_PREMIUM_IN_THE_MEANTIME)
[style] ~46-~46: ‘in the meantime’ might be wordy. Consider a shorter alternative.
Context: ...If you have changed the encryption key in the meantime*: Home Assistant can not decrypt it on...
(EN_WORDINESS_PREMIUM_IN_THE_MEANTIME)
[style] ~46-~46: Unless you want to emphasize “not”, use “cannot” which is more common.
Context: ...n key in the meantime**: Home Assistant can not decrypt it on the fly. You need the enc...
(CAN_NOT_PREMIUM)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
🔇 Additional comments (1)
source/more-info/backup-emergency-kit.markdown (1)
38-38
: Step Clarity is ClearThe updated step “4. To generate a new encryption key, select Next, then select Change encryption key.” is straightforward and improves user guidance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @c0ffeeca7 👍
../Frenck
Proposed change
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit