8000 Fix: update seventeentrack example card by override80 · Pull Request #34198 · home-assistant/home-assistant.io · GitHub
[go: up one dir, main page]

Skip to content

Fix: update seventeentrack example card #34198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

override80
Copy link
Contributor
@override80 override80 commented Aug 8, 2024

This is to match integration changes as of Home Assistant version 2024.8. Sensor names are now defaulting to "17track_*" and since they starts with numbers, a diffferent syntax is required.

Proposed change

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue: fixes #

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Summary by CodeRabbit

  • New Features
    • Updated package tracking integration to utilize a different state sensor for improved clarity in tracking packages in transit.
  • Bug Fixes
    • Adjusted the data source for package attributes to ensure reliable access to in-transit package information.

This is to match integration changes as of Home Assistant version 2024.8. Sensor names are now defaulting to "17track_*" and since they starts with numbers, a diffferent syntax is required.
@home-assistant home-assistant bot added the current This PR goes into the current branch label Aug 8, 2024
Copy link
Contributor
coderabbitai bot commented Aug 8, 2024
Walkthrough

Walkthrough

The recent changes involve updating the reference to a package tracking sensor in a markdown template. The attribute access method was modified for clarity, shifting from a specific named sensor to a more generalized format. This adjustment retains the original functionality while enhancing the readability and consistency of the codebase.

Changes

Files Change Summary
source/_integrations/seventeentrack.markdown Updated sensor reference from states.sensor.seventeentrack_packages_in_transit.attributes.packages to states.sensor['17track_in_transit'].attributes.packages for clarity.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Template
    participant Sensor

    User->>Template: Request package tracking info
    Template->>Sensor: Access package data
    Sensor-->>Template: Return package data
    Template-->>User: Display package info
Loading

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
netlify bot commented Aug 8, 2024

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit 2fa3e1d
🔍 Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/66b490dd4376910008ba32d4
😎 Deploy Preview https://deploy-preview-34198--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member
@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @override80 👍

../Frenck

@frenck frenck merged commit 4db0d67 into home-assistant:current Aug 8, 2024
6 checks passed
erictrudeau pushed a commit to erictrudeau/home-assistant.io that referenced this pull request Aug 9, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 9, 2024
@override80 override80 deleted the patch-1 branch August 25, 2024 19:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
current This PR goes into the current branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0