-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
Fix: update seventeentrack example card #34198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is to match integration changes as of Home Assistant version 2024.8. Sensor names are now defaulting to "17track_*" and since they starts with numbers, a diffferent syntax is required.
WalkthroughWalkthroughThe recent changes involve updating the reference to a package tracking sensor in a markdown template. The attribute access method was modified for clarity, shifting from a specific named sensor to a more generalized format. This adjustment retains the original functionality while enhancing the readability and consistency of the codebase. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Template
participant Sensor
User->>Template: Request package tracking info
Template->>Sensor: Access package data
Sensor-->>Template: Return package data
Template-->>User: Display package info
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @override80 👍
../Frenck
This is to match integration changes as of Home Assistant version 2024.8. Sensor names are now defaulting to "17track_*" and since they starts with numbers, a diffferent syntax is required.
Proposed change
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit