8000 Update prometheus-client to 0.17.1 by rcloran · Pull Request #97998 · home-assistant/core · GitHub
[go: up one dir, main page]
Skip to content

Update prometheus-client to 0.17.1 #97998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 8, 2023
Merged

Update prometheus-client to 0.17.1 #97998

merged 1 commit into from
Aug 8, 2023

Conversation

rcloran
Copy link
Contributor
@rcloran rcloran commented Aug 7, 2023

Proposed change

The version that Home Assistant currently depends on is from 2019. The best changelog I can find since then is on the project's release page: https://github.com/prometheus/client_python/releases

Highlights that might be useful (other than just general code hygiene of keeping current where possible):

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link
home-assistant bot commented Aug 7, 2023

Hey there @knyar, mind taking a look at this pull request as it has been labeled with an integration (prometheus) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of prometheus can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign prometheus Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@rcloran
Copy link
Contributor Author
rcloran commented Aug 7, 2023

Example output from a minimal hass with prometheus-client 0.7.1: https://gist.github.com/rcloran/5f6c40abc4dcf0eb382b5079f70c6f84
Example output from a minimal hass with prometheus-client 0.17.1: https://gist.github.com/rcloran/a0d7d67c89e8cad9c8b297bca9bf9cb8

Differences: https://gist.github.com/rcloran/7133ee0b6d71138dfa998aae49883b16

knyar
knyar approved these changes Aug 8, 2023
View reviewed changes
Copy link
Contributor
@knyar knyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for checking the changelog and sharing the diff.

frenck
frenck approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member
@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @rcloran 👍

../Frenck

@frenck frenck merged commit dfdf592 into home-assistant:dev Aug 8, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

@knyar knyar knyar approved these changes

Assignees
No one assigned
Labels
cla-signed dependency integration: prometheus Quality Scale: No score small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rcloran @frenck @knyar
0