8000 Improve Diagnostics result type by epenet · Pull Request #85603 · home-assistant/core · GitHub
[go: up one dir, main page]
Skip to content

Improve Diagnostics result type #85603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

Improve Diagnostics result type #85603

wants to merge 6 commits into from

Conversation

epenet
Copy link
Contributor
@epenet epenet commented Jan 10, 2023

Proposed change

As an alternative to #85525

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@epenet epenet requested a review from a team as a code owner January 10, 2023 12:01
@home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (diagnostics) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of diagnostics can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign diagnostics Removes the current integration label and assignees on the issue, add the integration domain after the command.

@epenet epenet marked this pull request as draft January 10, 2023 12:02
@epenet epenet force-pushed the DiagnosticsContent branch from adf0e1f to f027c2b Compare January 10, 2023 12:10
@epenet epenet force-pushed the DiagnosticsContent branch from c9281a2 to 0d41a2a Compare January 11, 2023 08:11
This was referenced Jan 11, 2023
Closed
Merged
@epenet epenet closed this Feb 7, 2023
@epenet epenet deleted the DiagnosticsContent branch February 7, 2023 16:25
@github-actions github-actions bot locked and limited conversation to collaborators Feb 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dmulcahey dmulcahey Awaiting requested review from dmulcahey dmulcahey will be requested when the pull request is marked ready for review dmulcahey is a code owner

@Adminiuga Adminiuga Awaiting requested review from Adminiuga Adminiuga will be requested when the pull request is marked ready for review Adminiuga is a code owner

@puddly puddly Awaiting requested review from puddly puddly will be requested when the pull request is marked ready for review puddly is a code owner

@TheJulianJES TheJulianJES Awaiting requested review from TheJulianJES TheJulianJES will be requested when the pull request is marked ready for review TheJulianJES is a code owner

@gjohansson-ST gjohansson-ST Awaiting requested review from gjohansson-ST gjohansson-ST will be requested when the pull request is marked ready for review gjohansson-ST is a code owner

@rytilahti rytilahti Awaiting requested review from rytilahti rytilahti will be requested when the pull request is marked ready for review rytilahti is a code owner

@syssi syssi Awaiting requested review from syssi syssi will be requested when the pull request is marked ready for review syssi is a code owner

@starkillerOG starkillerOG Awaiting requested review from starkillerOG starkillerOG will be requested when the pull request is marked ready for review starkillerOG is a code owner

@frenck frenck Awaiting requested review from frenck frenck will be requested when the pull request is marked ready for review frenck is a code owner

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees
No one assigned
Labels
cla-signed code-quality integration: diagnostics Quality Scale: internal small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@epenet
0