8000 Enable strict typing for zeroconf by KapJI · Pull Request #48450 · home-assistant/core · GitHub
[go: up one dir, main page]
Skip to content

Enable strict typing for zeroconf #48450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 30, 2021
Merged

Enable strict typing for zeroconf #48450

merged 7 commits into from
Mar 30, 2021

Conversation

KapJI
Copy link
Member
@KapJI KapJI commented Mar 28, 2021 •
edited
Loading

Proposed change

Zeroconf is intended to use by other components which may want to be strictly typed. Therefore zeroconf component also needs to be strictly typed.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @bdraco, mind taking a look at this pull request as its been labeled with an integration (zeroconf) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@KapJI
Copy link
Member Author
KapJI commented Mar 28, 2021

For some reason mypy doesn't see typing info from zeroconf although zeroconf package is installed and it exposes typing info (marked with py.typed).

KapJI
KapJI commented Mar 28, 2021
View reviewed changes
@KapJI KapJI mentioned this pull request Mar 28, 2021
Open
@KapJI KapJI force-pushed the zeroconf-typing branch from 80029e2 to a8ab644 Compare March 28, 2021 23:29
KapJI
KapJI commented Mar 30, 2021
View reviewed changes
@KapJI KapJI marked this pull request as ready for review March 30, 2021 12:59
@KapJI
Copy link
Member Author
KapJI commented Mar 30, 2021

@bdraco it's finally ready for review, please take a look 🙂

bdraco
bdraco reviewed Mar 30, 2021
View reviewed changes
bdraco
bdraco approved these changes Mar 30, 2021
View reviewed changes
Copy link
Member
@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, testing passed

@bdraco bdraco merged commit 82c9482 into home-assistant:dev Mar 30, 2021
@KapJI KapJI deleted the zeroconf-typing branch March 30, 2021 17:19
@github-actions github-actions bot locked and limited conversation to collaborators Mar 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare left review comments

@bdraco bdraco bdraco approved these changes

Assignees

@bdraco bdraco

Labels
cla-signed code-quality integration: zeroconf
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KapJI @bdraco @MartinHjelmare @homeassistant
0