8000 Bump pyvera to 0.3.16 by maximvelichko · Pull Request #146089 · home-assistant/core · GitHub
[go: up one dir, main page]

Skip to content

Bump pyvera to 0.3.16 #146089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 4, 2025
Merged

Bump pyvera to 0.3.16 #146089

merged 7 commits into from
Jun 4, 2025

Conversation

maximvelichko
Copy link
Contributor
@maximvelichko maximvelichko commented Jun 3, 2025

Proposed change

Vera integration to support dual setpoint thermostats.

maximvelichko/pyvera#159

maximvelichko/pyvera@0.3.15...0.3.16

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Copy link
@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @maximvelichko

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link
home-assistant bot commented Jun 3, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft June 3, 2025 02:55
@maximvelichko maximvelichko marked this pull request as ready for review June 3, 2025 02:56
@home-assistant home-assistant bot dismissed their stale review June 3, 2025 02:56

Stale

@epenet epenet marked this pull request as draft June 3, 2025 05:18
@epenet
Copy link
Contributor
epenet commented Jun 3, 2025

Please run python3 -m script.gen_requirements_all to ensure all linked auto-generated files are updated.

@epenet epenet changed the title Update vera integration with the latest pyvera package Bump pyvera to 0.3.16 Jun 3, 2025
@maximvelichko maximvelichko marked this pull request as ready for review June 3, 2025 22:47
@maximvelichko maximvelichko requested a review from a team as a code owner June 3, 2025 23:40
@maximvelichko
Copy link
Contributor Author

Tests pass when run locally - both test/components/vera/*.py (that I potentially touched) and tests/components/recorder/test_purge.py (that failed in the PR build).

The failed test failed because of insufficient (?) timeout (or just slower agent VM).

@epenet
8000 Copy link
Contributor
epenet commented Jun 4, 2025

Tests have passed now... I suggest to not touch the PR anymore 😃

@MartinHjelmare MartinHjelmare merged commit 59ad026 into home-assistant:dev Jun 4, 2025
85 of 86 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0