8000 Fix Shelly BLU TRV calibrate button by thecode · Pull Request #146066 · home-assistant/core · GitHub
[go: up one dir, main page]
Skip to content

Fix Shelly BLU TRV calibrate button #146066

8000
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 2, 2025
Merged

Fix Shelly BLU TRV calibrate button #146066

merged 1 commit into from
Jun 2, 2025

Conversation

thecode
Copy link
Member
@thecode thecode commented Jun 2, 2025

Proposed change

Shelly BLU TRV supported was using a wrong model for Gen2 gateway instead of Gen3 gateway, the supported property was not used which is why it didn't fail the tests.

Additionally fixed references and in Shelly button platform to use the coordinator config model instead from the device since the device one can fail if the device is not initialized.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@thecode thecode added this to the 2025.6.0 milestone Jun 2, 2025
@home-assistant
Copy link
home-assistant bot commented Jun 2, 2025

Hey there @balloob, @bieniu, @chemelli74, @bdraco, mind taking a look at this pull request as it has been labeled with an integration (shelly) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of shelly can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign shelly Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

chemelli74
chemelli74 approved these changes Jun 2, 2025
View reviewed changes
Copy link
Contributor
@chemelli74 chemelli74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx !

bieniu
bieniu approved these changes Jun 2, 2025
View reviewed changes
Copy link
Member
@bieniu bieniu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@thecode
Copy link
Member Author
thecode commented Jun 2, 2025

Thanks @chemelli74 @bieniu

@thecode thecode merged commit 6692b9b into home-assistant:dev Jun 2, 2025
34 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bieniu bieniu bieniu approved these changes

@chemelli74 chemelli74 chemelli74 approved these changes

@balloob balloob Awaiting requested review from balloob balloob is a code owner

@bdraco bdraco Awaiting requested review from bdraco bdraco is a code owner

Assignees

@bieniu bieniu

@bdraco bdraco

@balloob balloob

@chemelli74 chemelli74

Labels
bugfix by-code-owner cherry-picked cla-signed integration: shelly Quality Scale: silver small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2025.6.0
Development

Successfully merging this pull request may close these issues.
6 participants
@thecode @bieniu @chemelli74 @frenck @bdraco @balloob
0