Nextbus self throttle #146064
Open
Nextbus self throttle #146064
+90
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should help avoid rate limit exceeded errors
8cc64b0 to
022e087
Compare
zweckj
reviewed
Jun 4, 2025
Comment on lines
+37
to
+38
| self.client: NextBusClient = NextBusClient(agency_id=agency) | ||
| self._agency: str = agency |
There was a problem hiding this comment.
Suggested change
| self.client: NextBusClient = NextBusClient(agency_id=agency) | |
| self._agency: str = agency | |
| self.client = NextBusClient(agency_id=agency) | |
| self._agency = agency |
types should be inferred here, no need for explicit typing
There was a problem hiding this comment.
Using basedpyright, it gives me this warning:
Type annotation for attribute
clientis required because this class is not decorated with@final[reportUnannotatedClassAttribute]
The rule seems to be new in basedpyright because type checking misses changed types otherwise.
I don't think it's worth doing for it's own sake, but since I'm updating the module, might as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Used new client feature to keep track of rate limits and self throttle when approaching the threshold. This will result in less errors and hopefully make it less likely that they block our UA if we're acting responsibly.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: