8000 Add support for icons in todo list items by rokam · Pull Request #146061 · home-assistant/core · GitHub
[go: up one dir, main page]
Skip to content

Add support for icons in todo list items #146061

8000
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Add support for icons in todo list items #146061

wants to merge 2 commits into from

Conversation

rokam
Copy link
Contributor
@rokam rokam commented Jun 2, 2025 •
edited
Loading

Proposed change

Add the ability to use icons together with todo items. This will improve usability for kids.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link
home-assistant bot commented Jun 2, 2025

Hey there @allenporter, mind taking a look at this pull request as it has been labeled with an integration (local_todo) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of local_todo can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign local_todo Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@home-assistant
Copy link
home-assistant bot commented Jun 2, 2025

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (todo) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of todo can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign todo Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

allenporter
allenporter requested changes Jun 2, 2025
View reviewed changes
Copy link
Contributor
@allenporter allenporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This requires an architectural discussion in the architecture repo (see pending creation time PR).

Icons are not part of rfc5545 so I am not necessarily in favor of this, but to motivate we need at least a few example integrations that can add this, not really a local todo only feature.

@rokam
Copy link
Contributor Author
rokam commented Jun 2, 2025

This requires an architectural discussion in the architecture repo (see pending creation time PR).

Icons are not part of rfc5545 so I am not necessarily in favor of this, but to motivate we need at least a few example integrations that can add this, not really a local todo only feature.

home-assistant/architecture#1243

@rokam rokam mentioned this pull request Jun 2, 2025
Open
9 tasks
@rokam rokam marked this pull request as ready for review June 2, 2025 23:38
@rokam rokam requested a review from a team as a code owner June 2, 2025 23:38
@rokam rokam changed the title feat(todo): add support for icons Add support for icons in todo list items Jun 2, 2025
@frenck
Copy link
Member
frenck commented Jun 3, 2025

This pull request depends on the resolution of an architectural discussion. For that reason, I'll go ahead and close it for now.

We can reopen this one, once the architectural proposal has been approved.

../Frenk

@frenck frenck closed this Jun 3, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jun 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@allenporter allenporter allenporter requested changes

Assignees

@allenporter allenporter

Labels
cla-signed core integration: local_todo integration: todo new-feature Quality Scale: internal Quality Scale: No score
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rokam @frenck @allenporter
31C3
0