8000 Add awesomeversion to dependency version checks by epenet · Pull Request #146047 · home-assistant/core · GitHub
[go: up one dir, main page]
Skip to content

Add awesomeversion to dependency version checks #14 8000 6047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 2, 2025
Merged

Add awesomeversion to dependency version checks #146047

merged 2 commits into from
Jun 2, 2025

Conversation

epenet
Copy link
Contributor
@epenet epenet commented Jun 2, 2025

Proposed change

Spotted in #146032

This will prevent new violations from coming in - even as we wait for existing violations to be resolved.

cc @cdce8p

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@epenet epenet requested a review from a team as a code owner June 2, 2025 13:30
@home-assistant home-assistant bot added cla-signed code-quality small-pr PRs with less than 30 lines. labels Jun 2, 2025
@cdce8p
Copy link
Member
cdce8p commented Jun 2, 2025

Let's just add this in #146032. We should have resolved all issues by next weekend.

@epenet
Copy link
Contributor Author
epenet commented Jun 2, 2025

Let's just add this in #146032. We should have resolved all issues by next weekend.

Your call... I figured it would be a shame if another integration managed to slip in before all prior violations are resolved

@cdce8p
Copy link
Member
cdce8p commented Jun 2, 2025

Let's just add this in #146032. We should have resolved all issues by next weekend.

Your call... I figured it would be a shame if another integration managed to slip in before all prior violations are resolved

Ok, let's do it! I can remove the exceptions together in #146032 once that is ready.

cdce8p
cdce8p approved these changes Jun 2, 2025
View reviewed changes
Copy link
Member
@cdce8p cdce8p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @epenet 👍🏻

@cdce8p cdce8p merged commit 87395ef into dev Jun 2, 2025
48 checks passed
@cdce8p cdce8p deleted the epenet-20250602-1527 branch June 2, 2025 15:28
@github-actions github-actions bot locked and limited conversation to collaborators Jun 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cdce8p cdce8p cdce8p approved these changes

@chemelli74 chemelli74 chemelli74 approved these changes

Assignees
No one assigned
Labels
cla-signed code-quality small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@epenet @cdce8p @chemelli74
0