8000 Adjust SamsungTV on/off logging by epenet · Pull Request #146045 · home-assistant/core · GitHub
[go: up one dir, main page]
Skip to content

Adjust SamsungTV on/off logging #146045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 3, 2025
Merged

Adjust SamsungTV on/off logging #146045

merged 2 commits into from
Jun 3, 2025

Conversation

epenet
Copy link
Contributor
@epenet epenet commented Jun 2, 2025 •
edited
Loading

Proposed change

We have many issues in SamsungTV with TVs unexpectedly going online or offline
This should help tracking even when debug mode is not enabled, whilst still keeping it at a low volume.

Used a similar logic as log-when-unavailable from quality scale.
https://developers.home-assistant.io/docs/core/integration-quality-scale/rules/log-when-unavailable

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@epenet epenet requested a review from chemelli74 as a code owner June 2, 2025 13:01
@home-assistant
Copy link
home-assistant bot commented Jun 2, 2025

Hey there @chemelli74, mind taking a look at this pull request as it has been labeled with an integration (samsungtv) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of samsungtv can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign samsungtv Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@epenet epenet added this to the 2025.6.0 milestone Jun 2, 2025
chemelli74
chemelli74 approved these changes Jun 2, 2025
View reviewed changes
Copy link
Contributor
@chemelli74 chemelli74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

frenck
frenck requested changes Jun 3, 2025
View reviewed changes
@home-assistant home-assistant bot marked this pull request as draft June 3, 2025 10:08
@home-assistant
Copy link
home-assistant bot commented Jun 3, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

frenck
frenck approved these changes Jun 3, 2025
View reviewed changes
Copy link
Member
@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @epenet 👍

../Frenck

@epenet epenet marked this pull request as ready for review June 3, 2025 10:30
@home-assistant home-assistant bot requested a review from frenck June 3, 2025 10:30
@epenet epenet merged commit 7f8b782 into dev Jun 3, 2025
34 checks passed
@epenet epenet deleted the epenet-20250602-1458 branch June 3, 2025 10:30
frenck pushed a commit that referenced this pull request Jun 4, 2025
@epenet @frenck
Adjust SamsungTV on/off logging (#146045)
e15edbd 
* Adjust SamsungTV on/off logging

* Update coordinator.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chemelli74 chemelli74 chemelli74 approved these changes

@frenck frenck Awaiting requested review from frenck

601F
Assignees

@chemelli74 chemelli74

Labels
bugfix by-code-owner cherry-picked cla-signed integration: samsungtv Quality Scale: No score small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2025.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@epenet @frenck @chemelli74
0