8000 Remove stale Shelly BLU TRV devices by thecode · Pull Request #145994 · home-assistant/core · GitHub
[go: up one dir, main page]
Skip to content

Remove stale Shelly BLU TRV devices #145994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Remove stale Shelly BLU TRV devices #145994

wants to merge 2 commits into from
+131 −3

Conversation

thecode
Copy link
Member
@thecode thecode commented Jun 1, 2025 •
edited
Loading

Proposed change

When we implemented support for Shelly BLU TRV (a Bluetooth device, needs a gateway) that is paired to Shelly Gen3 gateway, we didn't implement a way to remove it when you un-pair the device from the gateway.

This PR remove stale BLU TRV devices when we detect that the BLU TRV MAC address is no longer paired to the gateway.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link
home-assistant bot commented Jun 1, 2025

Hey there @balloob, @bieniu, @chemelli74, @bdraco, mind taking a look at this pull request as it has been labeled with an integration (shelly) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of shelly can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign shelly Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@thecode thecode added this to the 2025.6.0 milestone Jun 2, 2025
@thecode thecode marked this pull request as ready for review June 2, 2025 20:57
@chemelli74
Copy link
Contributor

Beside the fact that I'm not sure this is categorizable as a big fix, looks good

frenck
frenck requested changes Jun 3, 2025
View reviewed changes
Copy link
Member
@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey hey 👋

I don't fully understand which bug this is fixing. The PR description also doesn't provide the motivation for it (maybe you forgot or it went missing).

Could you clarify?

../Frenck

@home-assistant home-assistant bot marked this pull request as draft June 3, 2025 10:10
@home-assistant
Copy link
home-assistant bot commented Jun 3, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@thecode
Copy link
Member Author
thecode commented Jun 3, 2025

Hey hey 👋

I don't fully understand which bug this is fixing. The PR description also doesn't provide the motivation for it (maybe you forgot or it went missing).

Could you clarify?

../Frenck

Sorry, I first created the PR as draft to complete testing since I switched to another PR and forgot to update the description, I hope it is clear now.

As for #145994 (comment) I don't have clear understanding if this should be tagged as new feature or a bugfix, my first understanding was that since it cleans up something which is broken and doesn't bring any new user facing feature it should be a bugfix. We don't have any open issue about since most users probably didn't un-pair or paired a new device so this can wait for the next release, please add your opinion and I will update accordingly.

Thanks.

@thecode thecode marked this pull request as ready for review June 3, 2025 10:57
@home-assistant home-assistant bot requested a review from frenck June 3, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balloob balloob Awaiting requested review from balloob balloob is a code owner

@bieniu bieniu Awaiting requested review from bieniu bieniu is a code owner

@chemelli74 chemelli74 Awaiting requested review from chemelli74 chemelli74 is a code owner

@bdraco bdraco Awaiting requested review from bdraco bdraco is a code owner

@frenck frenck Awaiting requested review from frenck

Requested changes must be addressed to merge this pull request.

Assignees

@bieniu bieniu

@bdraco bdraco

@balloob balloob

@chemelli74 chemelli74

Labels
bugfix by-code-owner cla-signed integration: shelly Quality Scale: silver quality-scale
Projects
None yet
Milestone
2025.6.0
Development

Successfully merging this pull request may close these issues.
6 participants
@thecode @chemelli74 @frenck @bieniu @bdraco @balloob
0