8000 Bump pymodbus to 3.9.2 by crug80 · Pull Request #145948 · home-assistant/core · GitHub
[go: up one dir, main page]
Skip to content

Bump pymodbus to 3.9.2 #145948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 4, 2025
Merged

Bump pymodbus to 3.9.2 #145948

merged 2 commits into from
Jun 4, 2025

Conversation

crug80
Copy link
Contributor
@crug80 crug80 commented May 31, 2025 •
edited
Loading

Breaking change

Possible breaking change: Since at least pymodbus version 2.x, e.g. read_coils have returned bit coils in wrong order

The slave address 0 is now allowed only if the device answers with the same id 0. (see Release notes v. 3.8.6 )

Proposed change

The PR updates pymodbus aligning it at the last available release.
List of changes:
Release notes v. 3.8.3
Release notes v. 3.8.4
Release notes v. 3.8.5
Release notes v. 3.8.6
Release notes v. 3.9.0
Release notes v. 3.9.1
Release notes v. 3.9.2

Current version 3.8.2 seems to be releated to some issues opened (#138077 , #141459)

I'm using the version 3.9.2 currently at my production environment since 1 month ago, but additional tests in different environment are appreciated.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@TheJulianJES TheJulianJES changed the title Bump pymodbus 392 Bump pymodbus to 3.9.2 Jun 1, 2025
frenck
frenck approved these changes Jun 4, 2025
View reviewed changes
Copy link
Member
@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @crug80 👍

../Frenck

@frenck frenck merged commit 9b0db3b into home-assistant:dev Jun 4, 2025
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frenck frenck frenck approved these changes

Assignees
No one assigned
Labels
cla-signed dependency integration: modbus Quality Scale: No score small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crug80 @frenck
0