Fix stale options in here_travel_time #145911 10000
Open
+95
−102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ab79f06 to
a7f80dd
Compare
erwindouna
suggested changes
May 31, 2025
| config_entry.options.get(CONF_ARRIVAL_TIME, "") | ||
| ) | ||
| ) is not None: | ||
| arrival = next_datetime(conf_arrival) |
There was a problem hiding this comment.
You type the departure below. Why not the arrival? Also then, in the above lying codes you can also apply more typing then.
There was a problem hiding this comment.
arrival is also typed in line 331
There was a problem hiding this comment.
Ah yes, missed that one on the mobile. Then the last question: why not apply it on other parts as well if you start introducing it in methods.
There was a problem hiding this comment.
I apply it where mypy cannot infer the type on its own
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Changing the option "Route Mode" did not take effect until after a ConfigEntry reload. The reason was that
HereTravelTimeConfigwas populated at ConfigEntry creation and did not get updated when the options changed.Moving the whole parameter building logic to the coordinator always builds them just before the API request from the current values of
config_entry.dataandconfig_entry.optionsType of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: