8000 Remove address info from Rachio calendar events by brg468 · Pull Request #145896 · home-assistant/core · GitHub
[go: up one dir, main page]
Skip to content

Remove address info from Rachio calendar events #145896 8000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Remove address info from Rachio calendar events #145896

wants to merge 1 commit into from
+0 −7

Conversation

brg468
Copy link
Contributor
@brg468 brg468 8000 commented May 30, 2025 •
edited
Loading

Breaking change

I'm not sure I would call this a breaking change, as it was just a supplementary piece of data in the calendar event.

Proposed change

Rachio has relocated the base station address info to their 'Properties' endpoint, so it no longer shows up when querying base station data, throwing an error. Removing for now, perhaps later on if the Properties endpoint is added to the underlying lib we can re-add.

https://rachio.readme.io/reference/properties-homes

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes Rachio KeyError in calendar platform #145839
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@brg468 brg468 requested a review from bdraco as a code owner May 30, 2025 14:46
@home-assistant home-assistant bot added cla-signed integration: rachio small-pr PRs with less than 30 lines. labels May 30, 2025
@home-assistant
Copy link

Hey there @bdraco, @rfverbruggen, mind taking a look at this pull request as it has been labeled with an integration (rachio) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of rachio can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign rachio Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdraco bdraco Awaiting requested review from bdraco bdraco is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@bdraco bdraco

Labels
cla-signed integration: rachio Quality Scale: No score small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rachio KeyError in calendar platform
2 participants
@brg468 @bdraco
0