8000 Deprecate hddtemp by edenhaus · Pull Request #145850 · home-assistant/core · GitHub
[go: up one dir, main page]
Skip to content

Deprecate hddtemp #145850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 2, 2025
Merged

Deprecate hddtemp #145850

merged 1 commit into from
Jun 2, 2025

Conversation

edenhaus
Copy link
Member
@edenhaus edenhaus commented May 29, 2025 •
edited
Loading

Breaking change

Deprecate integration as additional system packages need to be installed, which are currently not installed in our docker container, which is used by all supported installation methods.

Proposed change

Deprecate integration as additional system packages need to be installed, which are currently not installed in our docker container, which is used by all supported installation methods.
Adding integration-specific system packages requires prior approval in an architecture discussion, and will only be considered if the use case is or is anticipated to be highly popular.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@edenhaus edenhaus added this to the 2025.6.0 milestone May 29, 2025
@home-assistant home-assistant bot added cla-signed deprecation Indicates a breaking change to happen in the future has-tests integration: hddtemp small-pr PRs with less than 30 lines. Quality Scale: legacy labels May 29, 2025
davet2001
davet2001 approved these changes May 31, 2025
View reviewed changes
Copy link
Contributor
@davet2001 davet2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The deprecation looks good to me.
I also note that according to analytics.home-assistant.io, nobody who is reporting metrics has this installed.

@edenhaus edenhaus merged commit 6d827cd into dev Jun 2, 2025
34 checks passed
@edenhaus edenhaus deleted the edenhaus-deprecate-hddtemp branch June 2, 2025 07:45
@github-actions github-actions bot locked and limited conversation to collaborators Jun 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@davet2001 davet2001 davet2001 approved these changes

Assignees
No one assigned
Labels
cherry-picked cla-signed deprecation Indicates a breaking change to happen in the future has-tests integration: hddtemp Quality Scale: legacy small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2025.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@edenhaus @davet2001 @frenck
0