8000 Reolink fallback to download command for playback by starkillerOG · Pull Request #145842 · home-assistant/core · GitHub
[go: up one dir, main page]
Skip to content

Reolink fallback 8000 to download command for playback #145842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 29, 2025
Merged

Reolink fallback to download command for playback #145842

merged 5 commits into from
May 29, 2025

Conversation

starkillerOG
Copy link
Contributor

Breaking change

Proposed change

If the playback command returns the wrong content-type, fall back to the download command to get a mp4.
The latest firmware update of the "Reolink Duo 3V PoE" seems to have changed the return type of the playback command to "video/x-flv" just like what happend with the home hub during a firmware update.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@starkillerOG starkillerOG mentioned this pull request May 29, 2025
Closed
@starkillerOG starkillerOG added this to the 2025.6.0 milestone May 29, 2025
edenhaus
edenhaus approved these changes May 29, 2025
View reviewed changes
Copy link
Member
@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @starkillerOG 👍

@edenhaus edenhaus merged commit 9687a34 into home-assistant:dev May 29, 2025
34 checks passed
@starkillerOG starkillerOG deleted the reolink_playback_x-flv branch May 29, 2025 15:33
bramkragten pushed a commit that referenced this pull request May 30, 2025
@starkillerOG @bramkragten
Reolink fallback to download command for playback (#145842)
0f7379c
XiaoLing-git pushed a commit to XiaoLing-git/core that referenced this pull request May 30, 2025
@starkillerOG @XiaoLing-git
Reolink fallback to download command for playback (home-assistant#145842
b22238b 
)
@jackschmidt jackschmidt mentioned this pull request May 30, 2025
Closed
@github-actions github-actions bot locked and limited conversation to collaborators May 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@edenhaus edenhaus edenhaus approved these changes

Assignees
No one assigned
Labels
bugfix by-code-owner cherry-picked cla-signed has-tests integration: reolink Quality Scale: platinum small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2025.6.0
Development

Successfully merging this pull request may close these issues.

Reolink playback expected video/mp4 but got video/x-flv
3 participants
@starkillerOG @edenhaus @bramkragten
0