8000 Avoid constant alias for integration DOMAIN by epenet · Pull Request #145788 · home-assistant/core · GitHub
[go: up one dir, main page]
Skip to content

Avoid constant alias for integration DOMAIN #145788 8000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 2, 2025
Merged

Avoid constant alias for integration DOMAIN #145788

merged 7 commits into from
Jun 2, 2025

Conversation

epenet
Copy link
Contributor
@epenet epenet commented May 28, 2025

Proposed change

We already have checks to ensure that DOMAIN always has an alias when imported from another integration

This does the opposite - drop the alias if it is from the same integration.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant home-assistant bot added cla-signed code-quality small-pr PRs with less than 30 lines. labels May 28, 2025
@epenet epenet force-pushed the epenet-20250528-1227 branch from 9e2217b to 3397c9a Compare May 28, 2025 10:34
This was referenced May 28, 2025
Merged
Merged
Merged
This was referenced May 28, 2025
Merged
Merged
This was referenced Jun 2, 2025
Merged
Merged
@epenet epenet marked this pull request as ready for review June 2, 2025 06:56
@epenet epenet requested a review from a team as a code owner June 2, 2025 06:56
edenhaus
edenhaus approved these changes Jun 2, 2025
View reviewed changes
Copy link
Member
@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this PR as it was a pain to import the domain of the integration in the tests with an alias :) Thanks @epenet 👍

@epenet epenet merged commit 5a727a4 into dev Jun 2, 2025
48 checks passed
@epenet epenet deleted the epenet-20250528-1227 branch June 2, 2025 08:37
@github-actions github-actions bot locked and limited conversation to collaborators Jun 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

@edenhaus edenhaus edenhaus approved these changes

Assignees
No one assigned
Labels
cla-signed code-quality small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@epenet @frenck @edenhaus @thecode
0