8000 Basic entity class for Imeon inverter integration by Imeon-Energy · Pull Request #145778 · home-assistant/core · GitHub
[go: up one dir, main page]
Skip to content

Basic entity class for Imeon inverter integration #145778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: dev
Choose a base branch
from
Open

Basic entity class for Imeon inverter integration #145778

wants to merge 7 commits into from
+57 −38

Conversation

Imeon-Energy
Copy link
Contributor

Proposed change

Use of a basic entity class, before adding more sensors and platforms (cf #145694).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@Imeon-Energy Imeon-Energy mentioned this pull request May 28, 2025
Draft
19 tasks
joostlek
joostlek reviewed May 28, 2025
View reviewed changes
joostlek
joostlek reviewed May 28, 2025
View reviewed changes
@Imeon-Energy
Copy link
Contributor Author

I can't figure out why my generated snapshots are different from the previous ones, even though I didn't change anything with the sensors so far, any ideas ?

@joostlek
Copy link
Member

Regenerate translations, delete snapshots and regenerate them again

@Imeon-Energy
Copy link
Contributor Author

Regenerate translations, delete snapshots and regenerate them again

Thank you, I've been struggling with this for a while

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joostlek joostlek joostlek left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
by-code-owner cla-signed code-quality has-tests integration: imeon_inverter Quality Scale: bronze
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Imeon-Energy @joostlek @TheBushBoy
0