Replace foscam dependency #145766
< 8000 div class="gh-header-actions mt-0 mb-3 mb-md-2 ml-1 flex-md-order-1 flex-shrink-0 d-flex flex-items-center gap-1">Replace foscam dependency #145766
Conversation
|
Hey there @krmarien, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
|
@joostlek I’m one of the developers from FOSCAM. We had a brief communication last month regarding the integration library. |
Please update the PR description, and fill in details:
|
|
1.new dependency repository
|
|
@epenet Understood, these are some of my information. I don't have much experience in developing open source projects. If there are any errors in the information, I will cooperate and make necessary modifications in a timely manner |
|
So the requirements for new dependencies are here https://developers.home-assistant.io/docs/core/integration-quality-scale/rules/dependency-transparency. I think the only thing that is missing is that the releases should be tagged |
|
@joostlek 1.The source code of the dependency must be available under an OSI-approved license. I have already licensed my project under the GPL-3.0 License.2.The dependency must be available on PyPI. I have uploaded my dependency library to PyPI.3.Packages published to PyPI should be built and released through a public CI pipeline. I uploaded the dependency using a public CI workflow.4.The versions of the dependency published on PyPI should correspond to the tagged versions in the publicly accessible online repository. The versions are consistent.I'm not sure if I’ve missed any steps — would you please let me know if anything needs correction? I’ll update it promptly. Thank you |
These are empty: |
|
@epenet Thank you for the reminder, I did miss that step |
|
@epenet I believe I have completed the steps you just mentioned. |
|
There is no need to do Also, please run the test suite locally with ==================================== ERRORS ====================================
___________________ ERROR collecting tests/components/foscam ___________________
tests/components/foscam/conftest.py:3: in <module>
from libpyfoscam.foscam import (
E ModuleNotFoundError: No module named 'libpyfoscam'
=========================== short test summary info ============================
ERROR tests/components/foscam - ModuleNotFoundError: No module named 'libpyfoscam'
!!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!! |
|
@epenet The test files have been updated according to your requirements and are now running successfully locally. Thank you again for your patient guidance! |
|
@joostlek Hello, I'm sorry to bother you. I'd like to kindly ask when my PR might be merged. |
Breaking change
Proposed change
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: