8000 Smarla integration sensor platform by rlint-explicatis · Pull Request #145748 · home-assistant/core · GitHub
[go: up one dir, main page]
Skip to content

Smarla integration sensor platform #145748

< 8000 div class="gh-header-actions mt-0 mb-3 mb-md-2 ml-1 flex-md-order-1 flex-shrink-0 d-flex flex-items-center gap-1">
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 9 commits into
base: dev
Choose a base branch
from
Draft

Smarla integration sensor platform #145748

wants to merge 9 commits into from
+422 −29

Conversation

rlint-explicatis
Copy link
Contributor
@rlint-explicatis rlint-explicatis commented May 27, 2025 •
edited
Loading

Proposed change

Sensor platform is added to the smarla integration, introducing 4 new entitities.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @explicatis, mind taking a look at this pull request as it has been labeled with an integration (smarla) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of smarla can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign smarla Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@rlint-explicatis rlint-explicatis mentioned this pull request May 27, 2025
Open
8 tasks
@rlint-explicatis
Copy link
Contributor Author

Propably needs to be rebased due to PR dependencies

@rlint-explicatis rlint-explicatis marked this pull request as ready for review May 27, 2025 20:59
@rlint-explicat 8000 is rlint-explicatis marked this pull request as draft May 28, 2025 09:12
@rlint-explicatis
Copy link
Contributor Author
rlint-explicatis commented May 28, 2025 •
edited
Loading

Do not review the test files yet. Needs to be adjusted and rebased once #145803 is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
by-code-owner cla-signed has-tests integration: smarla new-feature new-platform Quality Scale: bronze
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rlint-explicatis @zweckj
0