8000 Add level of collections in Immich media source tree by mib1185 · Pull Request #145734 · home-assistant/core · GitHub
[go: up one dir, main page]
Skip to content

Add level of collections in Immich media source tree #145734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 28, 2025
Merged

Add level of collections in Immich media source tree #145734

merged 3 commits into from
May 28, 2025

Conversation

mib1185
Copy link
Contributor
@mib1185 mib1185 commented May 27, 2025 •
edited
Loading

Proposed change

This is the pre-work to later allow different layers of collections (eq. albums, tags, all, ...)
ref: #145691 (comment)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out corre 8000 ctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@mib1185 mib1185 added this to the 2025.6.0 milestone May 27, 2025
@mib1185 mib1185 changed the title Add layer for collections in Immich media source tree Add level of collections in Immich media source tree May 27, 2025
@mib1185 mib1185 merged commit afa97f8 into dev May 28, 2025
34 checks passed
@mib1185 mib1185 deleted the immich/add-collections-layer-in-media-source branch May 28, 2025 18:51
bramkragten pushed a commit that referenced this pull request May 28, 2025
@mib1185 @bramkragten
Add level of collections in Immich media source tree (#145734)
cd133cb 
* add layer for collections in media source tree

* re-arange tests, add test for collection layer

* fix
@github-actions github-actions bot locked and limited conversation to collaborators May 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zweckj zweckj zweckj approved these changes

Assignees
No one assigned
Labels
bugfix by-code-owner cherry-picked cla-signed has-tests integration: immich Quality Scale: silver
Projects
None yet
Milestone
2025.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mib1185 @zweckj @bramkragten
0