8000 Enforce async_load_fixture in async test functions by epenet · Pull Request #145709 · home-assistant/core · GitHub
[go: up one dir, main page]
Skip to content

Enforce async_load_fixture in async test functions #145709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 7 commits into
base: dev
Choose a base branch
from
Draft

Enforce async_load_fixture in async test functions #145709

wants to merge 7 commits into from
+94 −5

Conversation

epenet
Copy link
Contributor
@epenet epenet commented May 27, 2025 •
edited
Loading

Proposed change

SSIA, as follow-up to #144534
If a function is async, and

  • it has a call to load_fixture, then the call should be migrated to async_load_fixture
  • it has a call to load_json_array_fixture, then the call should be migrated to async_load_json_array_fixture
  • it has a call to load_json_object_fixture, then the call should be migrated to async_load_json_object_fixture

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @ispysoftware, mind taking a look at this pull request as it has been labeled with an integration (agent_dvr) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of agent_dvr can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign agent_dvr Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@home-assistant
Copy link

Hey there @bieniu, mind taking a look at this pull request as it has been labeled with an integration (airly) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of airly can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign airly Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@home-assistant
Copy link

Hey there @airgradienthq, @joostlek, mind taking a look at this pull request as it has been labeled with an integration (airgradient) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of airgradient can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign airgradient Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

This was referenced May 27, 2025
Merged
Merged
Merged
@epenet epenet force-pushed the epenet-20250527-1510 branch from acbc473 to a2ab53f Compare May 27, 2025 14:46
@epenet epenet mentioned this pull request May 28, 2025
Merged
19 tasks
This was referenced Jun 2, 2025
Open
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bieniu bieniu

@joostlek joostlek

Labels
cla-signed code-quality has-tests integration: agent_dvr integration: airgradient integration: airly Quality Scale: No score small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@epenet @bieniu @joostlek
0