Update otp description for amazon_devices #145701
8000
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @chemelli74, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
joostlek
reviewed
May 27, 2025
| @@ -5,7 +5,7 @@ | |||
| "data_description_country": "The country of your Amazon account.", | |||
| "data_description_username": "The email address of your Amazon account.", | |||
| "data_description_password": "The password of your Amazon account.", | |||
| "data_description_code": "The one-time password sent to your email address." | |||
| "data_description_code": "The one-time password to log in to your account. Either from your OTP application, or it will be sent to your email address." | |||
There was a problem hiding this comment.
The thing is, it can't be sent to your email address as we already need it at this step
There was a problem hiding this comment.
Would be nice and will allow sms
There was a problem hiding this comment.
updated the text so it reflects the current situation
bramkragten
pushed a commit
that referenced
this pull request
May 28, 2025
* Update otp description from amazon_devices * separate * Update strings.json
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be ap
2BD3
plied right now. Please check back later.
Breaking change
Proposed change
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: