Add 'AdvancedToggle' to list of supported Lutron button types #145676
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These buttons are no longer skipped when creating scenes, which matches other button types like Toggle, SingleAction, etc.
There was a problem hiding this comment.
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
Hey there @cdheiser, @wilburCforce, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
cdheiser
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
This tiny change creates Home Assistant scenes for AdvancedToggle button entries found when iterating Lutron keypads. Previously, these button types were skipped, resulting in the keypad button not being accessible through Home Assistant. This new behavior matches how Toggle, SingleAction and other buttons are currently handled in Home Assistant.
This change was tested on an existing Lutron installation that has multiple advanced toggle buttons, which it is using to control "motor" outputs according to the DbXmlInfo.xml. I am not familiar with Lutron's API, but in xml, these buttons seem to resemble SingleAction buttons. Using pylutron's button class and tap() method seems to control the button correctly in my limited test setup. I would appreciate feedback from someone more familiar with the Lutron API if there are other important differences that could effect other user's systems.
Some other users on the Home Assistant forums have asked about supporting these buttons, so hopefully helpful to others as well.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: