8000 Signal messenger flexible recipients by mathisdt · Pull Request #145654 · home-assistant/core · GitHub
[go: up one dir, main page]
Skip to content

Signal messenger flexible recipients #145654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

Signal messenger flexible recipients #145654

wants to merge 5 commits into from

Conversation

mathisdt
Copy link
@mathisdt mathisdt commented May 26, 2025 •
edited
Loading

Proposed change

Up to now, the signal_messenger integration was configured with a fixed list of recipients which could not be changed later. The consequence is that you have to configure the integration n times if you want to send messages to n people or groups.

This change enables the user to optionally overwrite the integration's global recipient list on a per-message basis by using the target attribute inherited from notify. The recipient list still has to be configured globally for the integration, at least as a default.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

mathisdt added 2 commits May 26, 2025 22:19
@mathisdt
Flexibilize recipients in signal_messenger integration
3090979 
This enables the user to overwrite the default recipient list
(which is configured globally) on a per-message basis
by using the `target` attribute inherited from `notify`.
@mathisdt
Flexibilize recipients in signal_messenger integration
24cffee 
This enables the user to overwrite the default recipient list
(which is configured globally) on a per-message basis
by using the `target` attribute inherited from `notify`.
home-assistant[bot]
home-assistant bot previously requested changes May 26, 2025
View reviewed changes
Copy link
@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mathisdt

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant home-assistant bot marked this pull request as draft May 26, 2025 21:14
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant
Copy link

Hey there @bbernhard, mind taking a look at this pull request as it has been labeled with an integration (signal_messenger) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of signal_messenger can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign signal_messenger Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@mathisdt mathisdt marked this pull request as ready for review May 27, 2025 06:22
@home-assistant home-assistant bot dismissed their stale review May 27, 2025 06:22

Stale

erwindouna
erwindouna suggested changes May 27, 2025
View reviewed changes
@bbernhard
Copy link
Contributor

Thanks for the improvements! Looks good to me!

@mathisdt
Copy link
Author
mathisdt commented May 30, 2025 •
edited
Loading

Thanks for the improvements! Looks good to me!

Hi @bbernhard, thanks for having a look! As a first-time contributor, I have a question: how is the PR able to progress further? Can you approve it? Or do I need more patience, and in some days someone with write access will approve it once he/she sees that you agreed to the changes?

@bbernhard
Copy link
Contributor
bbernhard commented May 31, 2025 •
edited
Loading

Thanks for the improvements! Looks good to me!

Hi @bbernhard, thanks for having a look! As a first-time contributor, I have a question: how is the PR able to progress further? Can you approve it? Or do I need more patience, and in some days someone with write access will approve it once he/she sees that you agreed to the changes?

Just approved your changes. But I guess a core maintainer might need to approve your PR too. My last contribution is already a while ago, so unfortunately I can't remember anymore how it exactly worked - sorry!

@mathisdt mathisdt mentioned this pull request Jun 1, 2025
Open
8 tasks
7F48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erwindouna erwindouna erwindouna requested changes

@bbernhard bbernhard bbernhard approved these changes

@home-assistant home-assistant[bot] home-assistant[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
cla-signed has-tests integration: signal_messenger new-feature Quality Scale: legacy small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mathisdt @bbernhard @erwindouna
0