8000 Restore user customizations of deleted devices by emontnemery · Pull Request #145191 · home-assistant/core · GitHub
[go: up one dir, main page]
Skip to content
10000

Restore user customizations of deleted devices #145191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 10, 2025
Merged

Restore user customizations of deleted devices #145191

merged 6 commits into from
Jun 10, 2025

Conversation

emontnemery
Copy link
Contributor
@emontnemery emontnemery commented May 19, 2025 •
edited
Loading

Proposed change

Keep and restore user customizations of area_id, disabled_by, labels and name_by_user when restoring deleted devices

If the area_id no longer exists, it will not be restored
Any label which no longer exists will not be restored

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@emontnemery emontnemery requested a review from a team as a code owner May 19, 2025 09:18
MartinHjelmare
MartinHjelmare reviewed May 19, 2025
View reviewed changes
@MartinHjelmare MartinHjelmare marked this pull request as draft May 19, 2025 09:30
@emontnemery emontnemery marked this pull request as ready for review May 19, 2025 10:31
MartinHjelmare
MartinHjelmare reviewed May 19, 2025
View reviewed changes
@MartinHjelmare MartinHjelmare marked this pull request as draft May 19, 2025 12:15
@emontnemery emontnemery marked this pull request as ready for review May 20, 2025 07:39
MartinHjelmare
MartinHjelmare approved these changes May 22, 2025
View reviewed changes
Copy link
Member
@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should get approval in the core meeting too, before merging.

@MartinHjelmare MartinHjelmare marked this pull request as draft May 22, 2025 07:48
@emontnemery emontnemery marked this pull request as ready for review May 28, 2025 09:14
@emontnemery
Copy link
Contributor Author

This was discussed and approved in a core meeting May 28th

@emontnemery emontnemery merged commit 11d9014 into dev Jun 10, 2025
48 checks passed
@emontnemery emontnemery deleted the device_registry_restore_user_customizations branch 7014 June 10, 2025 09:47
@github-actions github-actions bot locked and limited conversation to collaborators Jun 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees
No one assigned
Labels
cla-signed core new-feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emontnemery @MartinHjelmare
0