Fix send telegram notification to multiple chats #144922
Conversation
There was a problem hiding this comment.
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
what happens if both chat bots have the same chat ids? |
This comment was marked as outdated.
This comment was marked as outdated.
@hanwg, The message will go out in the first one. There is a test for this: |
This comment was marked as outdated.
This comment was marked as outdated.
|
It has never worked to configure more than one platform so this isn't a critical fix. |
|
I'll close here now. |
|
@saippuakauppias The config flow PR for the telegram bot integration has been merged. You're welcome to adapt this branch to work with config entries. We can use the chat ID to look up the config entry by iterating the config entries for the telegram bot domain and their subentries. Each config subentry corresponds to one chat ID. |
Proposed change
This PR fixes an issue with the Telegram Bot integration when multiple bots are configured. Previously, when multiple telegram_bot entries were set up in configuration.yaml, messages were always sent through the last initialized bot, regardless of the specified target chat_id.
The fix maintains a list of all notification services and selects the appropriate one based on the target chat ID when sending messages. This ensures messages are routed through the correct bot.
Type of change
Additional information
Checklist
ruff format homeassistant tests)To help with the load of incoming pull requests: