8000 Use micro sign "\u00b5" instead of Greek small letter mu "\u03bc" for micro unit prefix (alt 2) by jbouwh · Pull Request #144898 · home-assistant/core · GitHub
[go: up one dir, main page]
Skip to content

Use micro sign "\u00b5" instead of Greek small letter mu "\u03bc" for micro unit prefix (alt 2) #144898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: dev
Choose a base branch
from
Draft

Use micro sign "\u00b5" instead of Greek small letter mu "\u03bc" for micro unit prefix (alt 2) #144898

wants to merge 3 commits into from
+23 −23

Conversation

jbouwh
Copy link
Contributor
@jbouwh jbouwh commented May 14, 2025 •
edited by emontnemery
Loading

Breaking change

Breaks sensors that pass their unit by config (e.g. MQTT discovery or YAML) or custom integrations that use the the other unicode.

Proposed change

To represent the micro sign there are 2 different UNICODE characters used:

https://www.compart.com/en/unicode/U+00B5
-> 0xC2 0xB5 `b'\xce\xbc``
µ: MICRO SIGN

https://www.compart.com/en/unicode/U+03BC
-> 0xCE 0xBC b'\xc2\xb5'
μ: Greek Small Letter Mu

According to The Unicode Consortium, the Greek letter character is preferred,[10] but implementations must recognize the micro sign as well, for compatibility with legacy character sets.

This PR changes occurrences of 'b'\xc2\xb5' to b'\xce\xbc'

To see the change impact the other way see #144853

Assumable is that this PR should be broken up in smaller part to ensure compatibility and communication.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant home-assistant bot added cla-signed core has-tests small-pr PRs with less than 30 lines. labels May 14, 2025
@jbouwh jbouwh marked this pull request as draft May 14, 2025 14:37
@jbouwh jbouwh changed the title Use b'\xc2\xb5' for micro sign instead of b'\xce\xbc` Use b'\xc2\xb5' for micro sign instead of b'\xce\xbc` alt 2 May 14, 2025
@jbouwh jbouwh mentioned this pull request May 14, 2025
Open
19 tasks
@codecov Codecov
Copy link
codecov bot commented May 14, 2025

❌ We are unable to process any of the uploaded JUnit XML files. Please ensure your files are in the right format.

emontnemery
emontnemery reviewed May 15, 2025
View reviewed changes
@jbouwh jbouwh changed the title Use b'\xc2\xb5' for micro sign instead of b'\xce\xbc` alt 2 Use b'\xce\xbc` for micro sign instead of Greek micro sign b'\xc2\xb5' alt 2 May 17, 2025
@emontnemery emontnemery changed the title Use b'\xce\xbc` for micro sign instead of Greek micro sign b'\xc2\xb5' alt 2 Use Greek small letter mu b'\xce\xbc` for micro sign instead of micro sign b'\xc2\xb5' alt 2 May 22, 2025
@emontnemery emontnemery changed the title Use Greek small letter mu b'\xce\xbc` for micro sign instead of micro sign b'\xc2\xb5' alt 2 Use Greek small letter mu b'\xce\xbc` instead of micro sign b'\xc2\xb5' for micro unit prefix (alt 2) May 22, 2025
@emontnemery emontnemery changed the title Use Greek small letter mu b'\xce\xbc` instead of micro sign b'\xc2\xb5' for micro unit prefix (alt 2) Use micro sign b'\xc2\xb5' instead of Greek small letter mu b'\xce\xbc` for micro unit prefix (alt 2) May 22, 2025
@jbouwh jbouwh changed the title Use micro sign b'\xc2\xb5' instead of Greek small letter mu b'\xce\xbc` for micro unit prefix (alt 2) Use micro sign "\u00b5" instead of Greek small letter mu "\u03bc" for micro unit prefix (alt 2) May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emontnemery emontnemery emontnemery left review comments

@Danielhiversen Danielhiversen Awaiting requested review from Danielhiversen Danielhiversen is a code owner

@syssi syssi Awaiting requested review from syssi syssi is a code owner

@joostlek joostlek Awaiting requested review from joostlek joostlek is a code owner

@synesthesiam synesthesiam Awaiting requested review from synesthesiam

@thecode thecode Awaiting requested review from thecode thecode is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
breaking-change cla-signed core has-tests small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbouwh @emontnemery
0