8000 Add forecast service to amberelectric by madpilot · Pull Request #144848 · home-assistant/core · GitHub
[go: up one dir, main page]
Skip to content

Add forecast service to amberelectric #144848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 38 commits into
base: dev
Choose a base branch
from
Open

Add forecast service to amberelectric #144848

wants to merge 38 commits into from
+788 −219

Conversation

madpilot
Copy link
Contributor
@madpilot madpilot 10000 commented May 13, 2025 •
edited by mib1185
Loading

Proposed change

This PR deprecates the forecast sensor, and replaces it with the get_forecasts action.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

PR: home-assistant/home-assistant.io#39072

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

madpilot added 18 commits March 11, 2022 14:17
@madpilot
Merge remote-tracking branch 'upstream/dev' into dev
954220c
@madpilot
Merge remote-tracking branch 'upstream/dev' into dev
b282aaa
@madpilot
Merge remote-tracking branch 'upstream/dev' into dev
1a0b281
@madpilot
Merge remote-tracking branch 'upstream/dev' into dev
42c449f
@madpilot
Merge remote-tracking branch 'upstream/dev' into dev
24f4d18
@joostlek joostlek changed the title Add usage service Add usage service to amberelectric May 15, 2025
joostlek
joostlek reviewed May 15, 2025
View reviewed changes
joostlek
joostlek reviewed May 15, 2025
View reviewed changes
joostlek
joostlek requested changes May 15, 2025
View reviewed changes
@madpilot madpilot changed the title Add usage service to amberelectric Add forecast service to amberelectric May 15, 2025
@madpilot madpilot requested a review from joostlek May 16, 2025 12:27
@madpilot madpilot mentioned this pull request May 17, 2025
Open
NoRi2909
NoRi2909 reviewed May 27, 2025
View reviewed changes
NoRi2909
NoRi2909 reviewed May 27, 2025
View reviewed changes
NoRi2909
NoRi2909 reviewed May 27, 2025
View reviewed changes
madpilot added 16 commits May 29, 2025 20:16
@madpilot madpilot force-pushed the amberelectric/usage-action branch from f034d70 to 77e6fd7 Compare May 29, 2025 12:02
@madpilot madpilot marked this pull request as ready for review May 29, 2025 12:38
@home-assistant home-assistant bot requested a review from joostlek May 29, 2025 12:38
@madpilot madpilot requested a review from NoRi2909 June 3, 2025 08:08
@mib1185 mib1185 added the deprecation Indicates a breaking change to happen in the future label Jun 3, 2025
@mib1185 mib1185 added new-feature and removed deprecation Indicates a breaking change to happen in the future labels Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joostlek joostlek Awaiting requested review from joostlek

@NoRi2909 NoRi2909 Awaiting requested review from NoRi2909

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
by-code-owner cla-signed has-tests integration: amberelectric new-feature Quality Scale: No score
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Amber Price Forecast has reduced from 24 hours to 3 hours (post the 5-minute pricing update).
4 participants
@madpilot @joostlek @NoRi2909 @mib1185
0