Add charging and preconditioning actions to Teslemetry #144184
+632
−85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoRi2909
reviewed
May 4, 2025
10000
59dcc5d to
250d025
Compare
NoRi2909
reviewed
May 6, 2025
250d025 to
a72fe9d
Compare
a72fe9d to
91fe192
Compare
NoRi2909
reviewed
May 14, 2025
joostlek
requested changes
May 26, 2025
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
NoRi2909
reviewed
May 29, 2025
Comment on lines
+147
to
+153
| - "[%key:common::time::monday%]" | ||
| - "[%key:common::time::tuesday%]" | ||
| - "[%key:common::time::wednesday%]" | ||
| - "[%key:common::time::thursday%]" | ||
| - "[%key:common::time::friday%]" | ||
| - "[%key:common::time::saturday%]" | ||
| - "[%key:common::time::sunday%]" |
There was a problem hiding this comment.
Correct me if I'm wrong, but I think this is not recommended.
So far I have only seen these in strings.json:
"selector": {
"days_of_week": {
"options": {
"monday": "[%key:common::time::monday%]",
"tuesday": "[%key:common::time::tuesday%]",
"wednesday": "[%key:common::time::wednesday%]",
"thursday": "[%key:common::time::thursday%]",
"friday": "[%key:common::time::friday%]",
"saturday": "[%key:common::time::saturday%]",
"sunday": "[%key:common::time::sunday%]"
}
}
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Add charging and preconditioning actions to Teslemetry
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: