8000 Add Freebox device connectivty and signal sensors by adriencog · Pull Request #144056 · home-assistant/core · GitHub
[go: up one dir, main page]
Skip to content

Add Freebox device connectivty and signal sensors #144056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

Add Freebox device connectivty and signal sensors #144056

wants to merge 1 commit into from
+133 −3

Conversation

adriencog
Copy link
Contributor

Breaking change

Proposed change

Freebox API exposes many interesting attributes, such as connectivity type or wifi band and signal strength.
By adding such attributes in HomeAssistant, it'll allow Freebox users to view their network status as they would in their Freebox App.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@adriencog adriencog requested a review from Quentame as a code owner May 1, 2025 14:30
@home-assistant
Copy link
home-assistant bot commented May 1, 2025

Hey there @hacf-fr, @Quentame, mind taking a look at this pull request as it has been labeled with an integration (freebox) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of freebox can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign freebox Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

joostlek
joostlek requested changes May 1, 2025
View reviewed changes
Copy link
Member
@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nowadays, these data points should be added as separate entities, so let's do that

@home-assistant home-assistant bot marked this pull request as draft May 1, 2025 14:34
@home-assistant
Copy link
home-assistant bot commented May 1, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@adriencog
Copy link
Contributor Author

Nowadays, these data points should be added as separate entities, so let's do that

@joostlek I have few questions then:

  1. Should I create 2 entities for signal strength ? (one for raw value, another for enum) or raw value only ?
  2. Should each entities be linked to its own device in the integration ? I would think so, but amount of new devices could be quite significant for some people I guess

@adriencog adriencog force-pushed the feat/freebox-device-tracker-attributes branch from 82a668b to 46a5f1a Compare May 28, 2025 12:59
@adriencog adriencog changed the title Add extra attributes for Freebox device tracker Add Freebox device connectivty and signal sensors May 28, 2025
@adriencog adriencog force-pushed the feat/freebox-device-tracker-attributes branch from 46a5f1a to bb4c38c Compare May 28, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joostlek joostlek joostlek requested changes

@Quentame Quentame Awaiting requested review from Quentame Quentame is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

@Quentame Quentame

Labels
cla-signed integration: freebox new-feature Quality Scale: No score
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adriencog @joostlek @Quentame
0