Add support for ELV-SH-CTV Sensor to homematicip_cloud #143737
Draft
+449
−106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joostlek
requested changes
May 14, 2025
Comment on lines
+326
to
+341
| @property | ||
| def extra_state_attributes(self) -> dict[str, Any]: | ||
| """Return the state attributes of the tilt sensor.""" | ||
| state_attr = super().extra_state_attributes | ||
|
|
||
| state_attr[ATTR_ACCELERATION_SENSOR_NEUTRAL_POSITION] = getattr( | ||
| self.functional_channel, "accelerationSensorNeutralPosition", None | ||
| ) | ||
| state_attr[ATTR_ACCELERATION_SENSOR_TRIGGER_ANGLE] = getattr( | ||
| self.functional_channel, "accelerationSensorTriggerAngle", None | ||
| ) | ||
| state_attr[ATTR_ACCELERATION_SENSOR_SECOND_TRIGGER_ANGLE] = getattr( | ||
| self.functional_channel, "accelerationSensorSecondTriggerAngle", None | ||
| ) | ||
|
|
||
| return state_attr |
There was a problem hiding this comment.
can these be changed? Can we make separate entities out of t 8000 hem?
There was a problem hiding this comment.
these are just config values. Make separate entities anyway?
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Add support for ELV-SH-CTV Sensor to homematicip_cloud.
To reduce complexity i had to refactor the async_setup_entity function in sensor.py
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: