8000 Extract default conversation agent by arturpragacz · Pull Request #142684 · home-assistant/core · GitHub
[go: up one dir, main page]
Skip to content

Extract default conversation agent #142684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 19 commits into
base: dev
Choose a base branch
from
Open

Extract default conversation agent #142684

wants to merge 19 commits into from
+613 −423

Conversation

arturpragacz
Copy link
Contributor
@arturpragacz arturpragacz commented Apr 10, 2025 •
edited
Loading

Proposed change

Extract default conversation agent from the conversation integration into a separate component, improving the architecture and increasing modularity of code.

With this change conversation integration will stay responsible for defining the conversation entity and functionality related to that (chat log, etc.), whereas the new integration will provide the default conversation agent.

I tried to limit the diff here, so the split is not as clean as I would like yet. This will be improved in follow-up PRs.

I named the new component assist_conversation, per analogiam to openai_conversation, google_generative_ai_conversation, etc.; and also in line with assist_pipeline and assist_satellite.

TODO:

  • write docs

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @balloob, @synesthesiam, mind taking a look at this pull request as it has been labeled with an integration (assist_pipeline) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of assist_pipeline can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign assist_pipeline Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@home-assistant
Copy link

Hey there @home-assistant/core, @synesthesiam, mind taking a look at this pull request as it has been labeled with an integration (conversation) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of conversation can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign conversation Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

balloob
balloob reviewed Apr 14, 2025
View reviewed changes
balloob
balloob reviewed Apr 14, 2025
View reviewed changes
balloob
balloob reviewed Apr 14, 2025
View reviewed changes
@arturpragacz arturpragacz force-pushed the conversation/extract-default-agent branch from e10ee5c to e124b2f Compare April 17, 2025 04:51
@arturpragacz
Copy link
Contributor Author

When the PR is accepted, I will add docs (and brand).

Other than that the PR is ready to review. I think in the end the split came out quite clean, honestly more than I expected at the beginning. With this merged, the further work on improving the default agent will be much easier.

@arturpragacz arturpragacz marked this pull request as ready for review April 22, 2025 11:16
@arturpragacz arturpragacz requested review from synesthesiam and a team as code owners April 22, 2025 11:16
@arturpragacz arturpragacz requested a review from balloob May 12, 2025 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@synesthesiam synesthesiam Awaiting requested review from synesthesiam synesthesiam is a code owner

@balloob balloob Awaiting requested review from balloob balloob is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@balloob balloob

@synesthesiam synesthesiam

Labels
cla-signed core integration: assist_conversation integration: assist_pipeline integration: conversation new-integration Quality Scale: internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arturpragacz @balloob @synesthesiam
0