8000 Add Actronair integration by JagadishDhanamjayam · Pull Request #142369 · home-assistant/core · GitHub
[go: up one dir, main page]
Skip to content

Add Actronair integration #142369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 21 commits into
base: dev
Choose a base branch
from
Draft

Add Actronair integration #142369

wants to merge 21 commits into from
+1,860 −0

Conversation

JagadishDhanamjayam
Copy link

Proposed change

Adding a new integration for supporting ActronAir Neo AC Controllers

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • I have followed the [perfect PR recommendations][perfect-pr]
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

  • Documentation added/updated for [www.home-assistant.io][docs-repository]

If the code communicates with devices, web services, or third-party tools:

  • The [manifest file][manifest-docs] has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

home-assistant[bot]
home-assistant bot previously requested changes Apr 5, 2025
View reviewed changes
Copy link
@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @JagadishDhanamjayam

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant home-assistant bot marked this pull request as draft April 5, 2025 21:12
@home-assistant
Copy link
home-assistant bot commented Apr 5, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

home-assistant[bot]
home-assistant bot previously requested changes Apr 5, 2025
View reviewed changes
Copy link
@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When adding new integrations, limit included platforms to a single platform. Please reduce this PR to a single platform

This was referenced Apr 5, 2025
Open
Closed
@JagadishDhanamjayam JagadishDhanamjayam marked this pull request as ready for review April 6, 2025 07:32
@home-assistant home-assistant bot dismissed stale reviews from themself April 6, 2025 07:33

Stale

@JagadishDhanamjayam JagadishDhanamjayam mentioned this pull request Apr 10, 2025
Open
8 tasks
@edenhaus edenhaus changed the title Actronair integration Add Actronair integration Apr 29, 2025
NoRi2909
NoRi2909 reviewed Apr 29, 2025
View reviewed changes
zweckj
zweckj requested changes Apr 29, 2025
View reviewed changes
Copy link
Member
@zweckj zweckj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, please limit your initial PR to one platform.Also, I couldn't find your library code, it has to be hosted in a public repo with an OSI approved license and publish tagged releases to PyPi through automated CICD.

@home-assistant home-assistant bot marked this pull request as draft April 29, 2025 18:51
@JagadishDhanamjayam
Copy link
Author
JagadishDhanamjayam commented Jun 1, 2025 •
edited
Loading

Hi, please limit your initial PR to one platform.Also, I couldn't find your library code, it has to be hosted in a public repo with an OSI approved license and publish tagged releases to PyPi through automated CICD.

@zweckj Thanks for you review comment.
Unfortunately, I am not able to limit to one platform owing to the nature of the controller setup.
Detailed Explanation: A user account can have one or more aircons and it is required to provide an option to switch between these systems to control.

Library code is hosted in public repo with a OSI license and makes tagged releases PyPi via automated CI/CD
Public Repo: https://github.com/Actron-Air/ActronAirAPI
PyPI releases: https://pypi.org/project/actronair-api/

@JagadishDhanamjayam
Copy link
Author

@edenhaus documentation PR was raised long ago home-assistant/home-assistant.io#38474

@JagadishDhanamjayam JagadishDhanamjayam marked this pull request as ready for review June 1, 2025 09:43
@home-assistant home-assistant bot requested a review from zweckj June 1, 2025 09:44
@zweckj
Copy link
Member
zweckj commented Jun 1, 2025

This is not a valid reason. Even if that was the case then the first PR might only be the switch.
But to be honest that switch looks sketchy. What exactly does the user need to switch between? If there are different devices with different API versions you either set them up as different config entries, or different devices getting addressed through different endpoints.

@zweckj zweckj marked this pull request as draft June 1, 2025 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoRi2909 NoRi2909 NoRi2909 left review comments

@home-assistant home-assistant[bot] home-assistant[bot] left review comments

@zweckj zweckj Awaiting requested review from zweckj

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
cla-signed docs-missing has-tests integration: actronair new-integration quality-scale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JagadishDhanamjayam @zweckj @NoRi2909 @edenhaus
0