Add AC beep switch to SmartThings #142013
Conversation
There was a problem hiding this comment.
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
Hey there @joostlek, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
| Capability.SAMSUNG_CE_AIR_CONDITIONER_BEEP: ( | ||
| lambda status: status[Attribute.BEEP].value is not None | ||
| ), |
There was a problem hiding this comment.
are we sure that every AC that has this one works?
There was a problem hiding this comment.
This part I am not sure. I have only tested it on AR60F19D1XWNNA.
WindFree™ Inverter Split AC AR60F19D1XW, 5.30 kW (1.5) 3 Star (2025)
How do I make sure it exists on all models? Is there a way in documentation to check this.
Please let me know if you know how to get around this. Thanks!
There was a problem hiding this comment.
@joostlek I have joined the discord server.
username: mesas.destiny.0p
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
Breaking change
Proposed change
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: