8000 Allow to set translation_domain for SelectSelector and create helpers for sensor/switch device_class and sensor state_class by jbouwh · Pull Request #141544 · home-assistant/core · GitHub
[go: up one dir, main page]
Skip to content

Allow to set translation_domain for SelectSelector and create helpers for sensor/switch device_class and sensor state_class #141544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

Allow to set translation_domain for SelectSelector and create helpers for sensor/switch device_class and sensor state_class #141544

wants to merge 1 commit into from
+193 −100

Conversation

jbouwh
Copy link
Contributor
@jbouwh jbouwh 8000 commented Mar 27, 2025 •
edited
Loading

Proposed change

Allow to set translation_domain for SelectSelector and create helpers for sensor/switch device_class and sensor state_class. In this PR select selector helpers are created for sensordevice class en state class andswitch` device class.
They are applied to support sensor and switch entities on MQTT device subentries.

The integrations random, scrape, sql and template all have a select selector for sensor device classes,
random and template have select selectors for binary_sensor device classes.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request: TODO

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

home-assistant[bot]
home-assistant bot previously requested changes Mar 27, 2025
View reviewed changes
Copy link
@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a merge conflict.

@home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (sensor) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of sensor can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign sensor Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (switch) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of switch can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign switch Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@home-assistant
Copy link

Hey there @emontnemery, @bdraco, mind taking a look at this pull request as it has been labeled with an integration (mqtt) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of mqtt can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign mqtt Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@jbouwh
Allow to set translation_domain for SelectSelector and create helpers…
970f7cc 
… for sensor/switch device_class and sensor state_class
@jbouwh jbouwh force-pushed the select-selector-domain branch from 67a320a to 970f7cc Compare March 30, 2025 16:52
@jbouwh jbouwh mentioned this pull request Mar 31, 2025
Open
19 tasks
@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
If you are the author of this PR, please leave a comment if you want to keep it open. Also, please rebase your PR onto the latest dev branch to ensure that it's up to date with the latest changes.
Thank you for your contribution!

@github-actions github-actions bot added the stale label May 29, 2025
@jbouwh
Copy link
Contributor Author
jbouwh commented May 29, 2025

Not stale

@jbouwh jbouwh removed the stale label May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@home-assistant home-assistant[bot] home-assistant[bot] left review comments

@emontnemery emontnemery Awaiting requested review from emontnemery emontnemery will be requested when the pull request is marked ready for review emontnemery is a code owner

@bdraco bdraco Awaiting requested review from bdraco bdraco will be requested when the pull request is marked ready for review bdraco is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@bdraco bdraco

@emontnemery emontnemery

Labels
awaiting-frontend by-code-owner cla-signed core has-tests integration: mqtt integration: sensor integration: switch new-feature Quality Scale: internal Quality Scale: platinum
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jbouwh @bdraco @emontnemery
0