8000 Add bronze quality scale to Airzone by Noltari · Pull Request #141494 · home-assistant/core · GitHub
[go: up one dir, main page]
Skip to content

Add bronze quality scale to Airzone #141494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add bronze quality scale to Airzone #141494

wants to merge 1 commit into from

Conversation

Noltari
Copy link
Contributor
@Noltari Noltari commented Mar 26, 2025

Proposed change

Add bronze quality scale to Airzone integration.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@Noltari
Add bronze quality scale to Airzone
e6171d0 
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
@Noltari Noltari requested a review from a team as a code owner March 26, 2025 16:44
@NoRi2909
Copy link
Contributor

One suggestion for an additional small change:

grille_angles currently has the friendly name "Cold angle"

As this is apparently the air flow angle to use in "Cool" mode it would be more consistent to use "Cool angle" here.

This makes it consistent with heat_angles that has the friendly name "Heat angle".

dontinelli
dontinelli suggested changes Mar 27, 2025
View reviewed changes
Copy link
Contributor
@dontinelli dontinelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my view quality_scale.yaml should contain all rules (and the respective assessment), not only the bronze ones.

@home-assistant home-assistant bot marked this pull request as draft March 27, 2025 13:39
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

JackJPowell
JackJPowell reviewed Mar 28, 2025
View reviewed changes
homeassistant/components/airzone/quality_scale.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. quality_scale.yaml should contain the full list.
The quality scale should be reflective of the current state, regardless of plans for future PRs. Once those changes are implemented, you can update the quality_scale to reflect the new addition.

This was the advice I was given. Hopefully you find it helpful too.

@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
If you are the author of this PR, please leave a comment if you want to keep it open. Also, please rebase your PR onto the latest dev branch to ensure that it's up to date with the latest changes.
Thank you for your contribution!

@github-actions github-actions bot added the stale label May 27, 2025
@github-actions github-actions bot closed this Jun 3, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jun 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JackJPowell JackJPowell JackJPowell left review comments

@dontinelli dontinelli dontinelli requested changes

Assignees
No one assigned
Labels
by-code-owner cla-signed code-quality integration: airzone Quality Scale: No score quality-scale stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Noltari @NoRi2909 @JackJPowell @dontinelli
0