-
-
Notifications
You must be signed in to change notification settings - Fork 33.9k
Add integration: Aeroflex adjustable bed #140 8000 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @iddo-ra
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @iddo-laguna
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
def __init__( | ||
self, hass: HomeAssistant, entry: ConfigEntry, ble_device: BLEDevice | ||
) -> None: | ||
"""Initialize the bed entity.""" | ||
self.hass = hass | ||
self.entry = entry | ||
self._ble_device = ble_device | ||
self._attr_has_entity_name = True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
def __init__( | |
self, hass: HomeAssistant, entry: ConfigEntry, ble_device: BLEDevice | |
) -> None: | |
"""Initialize the bed entity.""" | |
self.hass = hass | |
self.entry = entry | |
self._ble_device = ble_device | |
self._attr_has_entity_name = True | |
_attr_has_entity_name = True | |
def __init__( | |
self, hass: HomeAssistant, entry: ConfigEntry, ble_device: BLEDevice | |
) -> None: | |
"""Initialize the bed entity.""" | |
self.hass = hass | |
self.entry = entry | |
self._ble_device = ble_device |
self._attr_name = name | ||
self._key = key | ||
self._command_up = command_up | ||
self._command_down = command_down | ||
self._attr_native_value = initial_value | ||
self._attr_native_min_value = MIN_ANGLE | ||
self._attr_native_max_value = max_angle | ||
self._attr_native_step = 1 | ||
self._attr_native_unit_of_measurement = DEGREE | ||
self._attr_icon = "mdi:bed-king" | ||
self._attr_unique_id = f"{ble_device.address}_{key}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be simplified by using NumberEntityDescription
class NumberEntityDescription(EntityDescription, frozen_or_thawed=True): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
Breaking change
Proposed change
Add Integration for Aeroflex Adjustable bed over BLE
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: