8000 Add integration: Aeroflex adjustable bed by iddora · Pull Request #140696 · home-assistant/core · GitHub
[go: up one dir, main page]

Skip to content

Add integration: Aeroflex adjustable bed #140 8000 696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

iddora
Copy link
@iddora iddora commented Mar 15, 2025

Breaking change

Proposed change

Add Integration for Aeroflex Adjustable bed over BLE

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Copy link
@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @iddo-ra

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant home-assistant bot marked this pull request as draft March 15, 2025 22:40
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

Copy link
@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @iddo-laguna

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant home-assistant bot marked this pull request as draft March 19, 2025 08:45
@iddora iddora marked this pull request as ready for review March 19, 2025 08:49
NoRi2909

This comment was marked as resolved.

Copy link
@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @iddora

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant home-assistant bot marked this pull request as draft March 21, 2025 07:35
@iddora iddora marked this pull request as ready for review March 21, 2025 07:38
8000
Comment on lines +22 to +30

def __init__(
self, hass: HomeAssistant, entry: ConfigEntry, ble_device: BLEDevice
) -> None:
"""Initialize the bed entity."""
self.hass = hass
self.entry = entry
self._ble_device = ble_device
self._attr_has_entity_name = True
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def __init__(
self, hass: HomeAssistant, entry: ConfigEntry, ble_device: BLEDevice
) -> None:
"""Initialize the bed entity."""
self.hass = hass
self.entry = entry
self._ble_device = ble_device
self._attr_has_entity_name = True
_attr_has_entity_name = True
def __init__(
self, hass: HomeAssistant, entry: ConfigEntry, ble_device: BLEDevice
) -> None:
"""Initialize the bed entity."""
self.hass = hass
self.entry = entry
self._ble_device = ble_device

Comment on lines +53 to +63
self._attr_name = name
self._key = key
self._command_up = command_up
self._command_down = command_down
self._attr_native_value = initial_value
self._attr_native_min_value = MIN_ANGLE
self._attr_native_max_value = max_angle
self._attr_native_step = 1
self._attr_native_unit_of_measurement = DEGREE
self._attr_icon = "mdi:bed-king"
self._attr_unique_id = f"{ble_device.address}_{key}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be simplified by using NumberEntityDescription

class NumberEntityDescription(EntityDescription, frozen_or_thawed=True):

Copy link
Member
@bieniu bieniu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@home-assistant home-assistant bot marked this pull request as draft March 28, 2025 09:20
Copy link

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
If you are the author of this PR, please leave a comment if you want to keep it open. Also, please rebase your PR onto the latest dev branch to ensure that it's up to date with the latest changes.
Thank you for your contribution!

@github-actions github-actions bot added the stale label May 27, 2025
@github-actions github-actions bot closed this Jun 3, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jun 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0