8000 Tilt Pi integration by michaelheyman · Pull Request #139726 · home-assistant/core · GitHub
[go: up one dir, main page]

Skip to content

Tilt Pi integration #139726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 65 commits into from
Jun 23, 2025
Merged
Changes from 1 commit
Commits
Show all changes
65 commits
Select commit Hold shift + click to select a range
c4d2c1f
Create component via script.scaffold
michaelheyman Feb 23, 2025
f1b7d61
Create sensor definition
michaelheyman Feb 23, 2025
f2bc36f
Define coordinator
michaelheyman Feb 23, 2025
f13ecb3
Define config flow
michaelheyman Feb 24, 2025
679bd80
Refine sensor definition and add tests
michaelheyman Feb 25, 2025
a9f80bf
Refine coordinator after testing end to end
michaelheyman Feb 27, 2025
e5c775a
Redefine sensor in a more idiomatic way
michaelheyman Feb 27, 2025
b6ad9c1
Use entity (common-module)
michaelheyman Feb 27, 2025
844a1d4
Follow config-flow conventions more closely
michaelheyman Feb 27, 2025
84ed1b8
Use custom ConfigEntry to conform to strict-typing
michaelheyman Feb 27, 2025
58b8c38
Define API object instead of using aio directly
michaelheyman Feb 27, 2025
78cde3d
Test before setup in init
michaelheyman Feb 28, 2025
f2c70f5
Add diagnostics
michaelheyman Feb 28, 2025
44c3c2c
Make some more quality changes
michaelheyman Mar 1, 2025
1eb10e4
Move scan interval to const
michaelheyman Mar 3, 2025
dff4984
Commit generated files
michaelheyman Mar 3, 2025
9503c5e
Add quality scale
michaelheyman Mar 3, 2025
beb38e3
Merge branch 'dev' into tilt-pi
michaelheyman Mar 4, 2025
bed25e0
feedback: Apply consistent language to Tilt Pi refs
michaelheyman Mar 5, 2025
cd0a178
Merge branch 'dev' into tilt-pi
michaelheyman Mar 6, 2025
d558469
feedback: Remove empty manifest fields
michaelheyman May 31, 2025
a86ea49
feedback: Use translations instead of hardcoded name
michaelheyman May 31, 2025
9a39f48
feedback: Remove diagnostics
michaelheyman Jun 1, 2025
1965042
feedback: Idiomatic and general improvements
michaelheyman Jun 1, 2025
5c7b37d
Merge branch 'dev' into tilt-pi
michaelheyman Jun 2, 2025
3e91a19
Use tilt-pi library
michaelheyman Jun 8, 2025
c197354
feedback: Coordinator data returns dict
michaelheyman Jun 9, 2025
e91eb08
feedback: Move client creation to coordinator
michaelheyman Jun 9, 2025
a2b49f6
feedback: Request only Tilt Pi URL from user
michaelheyman Jun 9, 2025
65d572b
Merge branch 'dev' into tilt-pi
michaelheyman Jun 10, 2025
9f1a0c4
Update homeassistant/components/tilt_pi/entity.py
michaelheyman Jun 11, 2025
02a57ca
Update homeassistant/components/tilt_pi/sensor.py
michaelheyman Jun 11, 2025
7e9499e
Update homeassistant/components/tilt_pi/entity.py
michaelheyman Jun 11, 2025
806774b
feedback: Avoid redundant keyword arguments in function calls
michaelheyman Jun 11, 2025
6589045
feedback: Remove unused models and variables
michaelheyman Jun 12, 2025
a3a6054
feedback: Use icons.json
michaelheyman Jun 12, 2025
d78b02d
feedback: Style best practices
michaelheyman Jun 13, 2025
5c47da2
Merge branch 'dev' into tilt-pi
michaelheyman Jun 13, 2025
d8eeae9
Update homeassistant/components/tilt_pi/entity.py
michaelheyman Jun 14, 2025
1c1d93f
Update tests/components/tilt_pi/test_config_flow.py
michaelheyman Jun 14, 2025
05700b9
feedback: Improve config flow unit tests
michaelheyman Jun 14, 2025
735d7f9
feedback: Patch TiltPi client mock
michaelheyman Jun 14, 2025
252626d
feedback: Mark entity-device-class as done
michaelheyman Jun 14, 2025
2a487ce
feedback: Align quaity scale with current state
michaelheyman Jun 15, 2025
9b738c0
feeback: Create brands file for Tilt brand
michaelheyman Jun 15, 2025
a725e78
feedback: Demonstrate recovery in config flow
michaelheyman Jun 15, 2025
834dcfd
feedback: Test coordinator behavior via sensors
michaelheyman Jun 15, 2025
3b92fa8
Merge branch 'dev' into tilt-pi
michaelheyman Jun 15, 2025
5a3e545
Update homeassistant/components/tilt_pi/config_flow.py
michaelheyman Jun 17, 2025
22bdffa
Update homeassistant/components/tilt_pi/coordinator.py
michaelheyman Jun 17, 2025
158056c
Update homeassistant/components/tilt_pi/quality_scale.yaml
michaelheyman Jun 17, 2025
a0e0d25
Update homeassistant/components/tilt_pi/quality_scale.yaml
michaelheyman Jun 17, 2025
0cebd49
Update homeassistant/components/tilt_pi/quality_scale.yaml
michaelheyman Jun 17, 2025
8aec831
Update homeassistant/components/tilt_pi/config_flow.py
michaelheyman Jun 17, 2025
28da7aa
feedback: Update tilt_pi quality scale
michaelheyman Jun 17, 2025
ad2c399
feedback: Move const to coordinator
michaelheyman Jun 17, 2025
8000
b7033d5
feedback: Correct strings.json for incorrect and missing fields
michaelheyman Jun 17, 2025
cb84f15
feedback: Use tiltpi package version published via CI
michaelheyman Jun 17, 2025
c181f1c
Merge branch 'dev' into tilt-pi
michaelheyman Jun 17, 2025
33c8855
Run ruff format manually
michaelheyman Jun 17, 2025
6322d16
Merge branch 'dev' into tilt-pi
michaelheyman Jun 17, 2025
30882d2
Add missing string for invalid host
michaelheyman Jun 17, 2025
ddcf2af
Merge branch 'dev' into tilt-pi
joostlek Jun 23, 2025
de5a6df
Fix
joostlek Jun 23, 2025
2e82b58
Fix
joostlek Jun 23, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Test before setup in init
  • Loading branch information
michaelheyman committed Feb 28, 2025
commit 78cde3d05fe40d7a9c494b5ef958079d1c5f2821
6 changes: 6 additions & 0 deletions homeassistant/components/tilt_pi/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,12 @@ async def async_setup_entry(hass: HomeAssistant, entry: TiltPiConfigEntry) -> bo
port=entry.data[CONF_PORT],
session=session,
)

try:
await client.get_hydrometers()
except Exception as e:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only catch bare exceptions in the config flow, we should be specific here

raise ConfigEntryNotReady(f"Cannot connect to Tilt Pi: {e}") from e

coordinator = TiltPiDataUpdateCoordinator(
hass=hass,
config_entry=entry,
Expand Down
0