10000 Add consumables for tplink tapo vacuums by rytilahti · Pull Request #136510 · home-assistant/core · GitHub
[go: up one dir, main page]
Skip to content

Add consumables for tplink tapo vacuums #136510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Jan 29, 2025
Merged

Add consumables for tplink tapo vacuums #136510

merged 23 commits into from
Jan 29, 2025

Conversation

rytilahti
Copy link
Member
@rytilahti rytilahti commented Jan 25, 2025 •
edited
Loading

Proposed change

Add consumable entities for tplink vacuums.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @bdraco, @sdb9696, mind taking a look at this pull request as it has been labeled with an integration (tplink) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of tplink can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign tplink Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@rytilahti rytilahti changed the title Initial implementation for tplink tapo vacuums Add consumables for tplink tapo vacuums Jan 26, 2025
@rytilahti rytilahti force-pushed the tplink/vacuum_cleaning_records branch from 413141b to 50c014b Compare January 26, 2025 14:14
@rytilahti rytilahti force-pushed the tplink/vacuum_consumables branch from ce6d5ab to 83cec2d Compare January 26, 2025 14:15
@rytilahti rytilahti changed the base branch from tplink/vacuum_cleaning_records to tplink/vacuum January 26, 2025 14:15
@rytilahti rytilahti added the waiting-for-upstream We're waiting for a change upstream label Jan 26, 2025
@rytilahti rytilahti removed the waiting-for-upstream We're waiting for a change upstream label Jan 27, 2025
Base automatically changed from tplink/vacuum to dev January 28, 2025 11:44
@rytilahti rytilahti marked this pull request as ready for review January 28, 2025 20:47
@rytilahti rytilahti requested a review from bdraco as a code owner January 28, 2025 20:47
bdraco
bdraco reviewed Jan 28, 2025
View reviewed changes
bdraco
bdraco reviewed Jan 28, 2025
View reviewed changes
@bdraco bdraco marked this pull request as draft January 29, 2025 00:27
@bdraco bdraco marked this pull request as ready for review January 29, 2025 14:14
@bdraco bdraco merged commit c7176f6 into dev Jan 29, 2025
32 checks passed
@bdraco bdraco deleted the tplink/vacuum_consumables branch January 29, 2025 14:23
zxdavb pushed a commit to zxdavb/hass that referenced this pull request Jan 29, 2025
@rytilahti @sdb9696
@bdraco @zxdavb
Add consumables for tplink tapo vacuums (home-assistant#136510)
ee89def 
Co-authored-by: Steven B <51370195+sdb9696@users.noreply.github.com>
Co-authored-by: J. Nick Koston <nick@koston.org>
zxdavb pushed a commit to zxdavb/hass that referenced this pull request Jan 29, 2025
@rytilahti @sdb9696
@bdraco @zxdavb
Add consumables for tplink tapo vacuums (home-assistant#136510)
b089341 
Co-authored-by: Steven B <51370195+sdb9696@users.noreply.github.com>
Co-authored-by: J. Nick Koston <nick@koston.org>
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bdraco bdraco bdraco approved these changes

Assignees

@bdraco bdraco

Labels
by-code-owner cla-signed integration: tplink new-feature Quality Scale: No score
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rytilahti @bdraco @sdb9696
0